All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Dave Hylands <dhylands@gmail.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: Regressions for older OMAP3503 silicon
Date: Wed, 05 Oct 2011 11:10:31 -0700	[thread overview]
Message-ID: <877h4j5my0.fsf@ti.com> (raw)
In-Reply-To: <CABi1daE-7OdgL5BqaLrB+X64-cf+kQMyXv9eSZOE79bRt+fMPw@mail.gmail.com> (Dave Hylands's message of "Wed, 5 Oct 2011 00:14:57 -0700")

Dave Hylands <dhylands@gmail.com> writes:

> Hi,
>
> I have an older overo board, which has an OMAP3503
>
> U-booot reports:
> OMAP3503-GP ES2.1, CPU-OPP2, L3-165MHz, Max CPU Clock 600 mHz
>
> In order to get the 2.6.39 kernel to boot, I had to make 2 modifications:
>
> In arch/arm/mach-omap2/pm34xx.c, in the omap_sram_idle routine I had
> to put an #if 0 around:
>
> #if 0
>        if (omap3_has_io_wakeup() &&
>            (per_next_state < PWRDM_POWER_ON ||
>             core_next_state < PWRDM_POWER_ON)) {
>                omap2_prm_set_mod_reg_bits(OMAP3430_EN_IO_MASK,
> WKUP_MOD, PM_WKEN);
>                omap3_enable_io_chain();
>        }
> #endif
>
> or I would get continuous
>
> Wake up daisy chain activation failed.
>
> messages on the console.

The need to comment this out suggests that omap3_has_io_wakeup() is
returning true for this SoC but should not.

Looking at mach-omap2/io.c, that feature flag is not set on the 3505 and
3517, but is set on the 3503:

	if (!cpu_is_omap3505() && !cpu_is_omap3517())
		omap_features |= OMAP3_HAS_IO_WAKEUP;

Adding a case for the 3503 here should fix this problem.

Maybe check other checks for cpu_is_omap3505() and see if those should
also be checking for the 3503.

Kevin



  parent reply	other threads:[~2011-10-05 18:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05  7:14 Regressions for older OMAP3503 silicon Dave Hylands
2011-10-05 16:26 ` Tony Lindgren
2011-10-05 18:01   ` Paul Walmsley
2011-10-05 18:19   ` Steve Sakoman
2011-10-05 18:59     ` Tony Lindgren
2011-10-06  6:29     ` Dave Hylands
2011-10-05 18:09 ` Paul Walmsley
2011-10-06  6:24   ` Dave Hylands
2011-10-06 16:14     ` Paul Walmsley
2011-10-06 14:23   ` Steve Sakoman
2011-10-05 18:10 ` Kevin Hilman [this message]
2011-10-05 18:35   ` Paul Walmsley
2011-10-05 19:48   ` Steve Sakoman
2011-10-05 21:20     ` Paul Walmsley
2011-10-05 23:28     ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877h4j5my0.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=dhylands@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.