From: Robert Jarzmik <robert.jarzmik@free.fr>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org
Subject: Re: DocG3 patch
Date: Mon, 19 Sep 2011 20:01:14 +0200 [thread overview]
Message-ID: <877h544djp.fsf@free.fr> (raw)
In-Reply-To: <1316409280.24366.60.camel@sauron> (Artem Bityutskiy's message of "Mon, 19 Sep 2011 08:14:34 +0300")
Artem Bityutskiy <dedekind1@gmail.com> writes:
> On Sun, 2011-09-18 at 12:03 +0200, Robert Jarzmik wrote:
>> Hello Artem,
>>
>> It's been 2 months, and I had no news.
>> The DocG3 driver was submitted and not reviewed in [1] and [2].
>>
>> Could you merge the patch into your tree please (patch in [2]) ?
>
> Oh, I missed your v2 completely.
>
> The problem I see with this driver is that it uses sysfs interfaces for
> debugging purposes. You should not do this - we have debugfs for stuff
> like that. I suggest you to just kill sysfs interfaces and re-send your
> patch. You can later add debugfs interfaces instead.
Converted sysfs -> debufs, and resent in V3.
Cheers.
--
Robert
prev parent reply other threads:[~2011-09-19 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-18 10:03 DocG3 patch Robert Jarzmik
2011-09-19 5:14 ` Artem Bityutskiy
2011-09-19 18:01 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877h544djp.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.