All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: linux-omap@vger.kernel.org, Paul Walmsely <paul@pwsan.com>,
	Benoit Cousson <b-cousson@ti.com>
Subject: Re: [PATCH/RFC 04/19] OMAP2+: voltage: start towards a new voltagedomain layer
Date: Fri, 25 Mar 2011 08:48:25 -0700	[thread overview]
Message-ID: <877hbnurp2.fsf@ti.com> (raw)
In-Reply-To: <AANLkTik6uz+SUHsZXzhJ8c6G7EdOt3ZjCWw2JUOPuZii@mail.gmail.com> (Jean Pihet's message of "Fri, 25 Mar 2011 09:59:52 +0100")

Hi Jean,

Jean Pihet <jean.pihet@newoldbits.com> writes:

> On Thu, Mar 24, 2011 at 1:00 AM, Kevin Hilman <khilman@ti.com> wrote:
>> Start cleaning up the voltage layer to have a voltage domain layer
>> that resembles thae structure of the existing clock and power domain
> s/thae/the
>
>> layers.  To that end:
> Extra space
>

Thanks for the review of this series.

When commenting on a patch (especially large ones) it helps if you
remove context that is not relevant to the patch.

For example, your two comments above are the only ones on this patch,
yet below you still have the entire patch context, which requires the
author to look through the whole patch again to see if there are other
comments. 

It is a great help to the author (and other reviewers) if the reply only
keeps the relevant context so it's obvious what the reply is to.

Thanks,

Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-03-25 15:48 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-24  0:00 [PATCH/RFC 00/19] OMAP: voltage layer cleanup and restructure Kevin Hilman
2011-03-24  0:00 ` [PATCH/RFC 01/19] OMAP2+: hwmod: remove unused voltagedomain pointer Kevin Hilman
2011-03-25  8:58   ` Jean Pihet
2011-03-25 14:24     ` Kevin Hilman
2011-03-24  0:00 ` [PATCH/RFC 02/19] OMAP2+: voltage: move PRCM mod offets into VC/VP structures Kevin Hilman
2011-03-24  0:00 ` [PATCH/RFC 03/19] OMAP2+: voltage: move prm_irqst_reg from VP into voltage domain Kevin Hilman
2011-03-24  0:00 ` [PATCH/RFC 04/19] OMAP2+: voltage: start towards a new voltagedomain layer Kevin Hilman
2011-03-25  8:59   ` Jean Pihet
2011-03-25 15:48     ` Kevin Hilman [this message]
2011-03-25 16:41       ` Jean Pihet
2011-03-24  0:00 ` [PATCH/RFC 05/19] OMAP3: voltage: rename "mpu" voltagedomain to "mpu_iva" Kevin Hilman
2011-03-24  0:00 ` [PATCH/RFC 06/19] OMAP3: voltagedomain data: add wakeup domain Kevin Hilman
2011-03-25  9:00   ` Jean Pihet
2011-03-24  0:00 ` [PATCH/RFC 07/19] OMAP3: voltage: add scalable flag to voltagedomain Kevin Hilman
2011-03-24  5:23   ` Vishwanath Sripathy
2011-03-24 14:12     ` Kevin Hilman
2011-03-24 14:54       ` Cousson, Benoit
2011-03-24 17:31         ` Vishwanath Sripathy
2011-03-24  0:00 ` [PATCH/RFC 08/19] OMAP2+: powerdomain: add voltagedomain to struct powerdomain Kevin Hilman
2011-03-25  9:05   ` Jean Pihet
2011-03-25 15:49     ` Kevin Hilman
2011-03-24  0:00 ` [PATCH/RFC 09/19] OMAP2: add voltage domains and connect to powerdomains Kevin Hilman
2011-03-24  0:00 ` [PATCH/RFC 10/19] OMAP3: powerdomain data: add voltage domains Kevin Hilman
2011-03-25  9:09   ` Jean Pihet
2011-03-25 15:51     ` Kevin Hilman
2011-03-25 16:43       ` Jean Pihet
2011-03-24  0:00 ` [PATCH/RFC 11/19] OMAP4: " Kevin Hilman
2011-03-24  0:00 ` [PATCH/RFC 12/19] OMAP2+: powerdomain: add voltage domain lookup during register Kevin Hilman
2011-03-25  9:18   ` Jean Pihet
2011-03-25 15:52     ` Kevin Hilman
2011-03-24  0:00 ` [PATCH/RFC 13/19] OMAP2+: voltage: keep track of powerdomains in each voltagedomain Kevin Hilman
2011-03-25  9:22   ` Jean Pihet
2011-03-25 15:56     ` Kevin Hilman
2011-03-25 16:52       ` Jean Pihet
2011-03-24  0:00 ` [PATCH/RFC 14/19] OMAP2+: voltage: split voltage controller (VC) code into dedicated layer Kevin Hilman
2011-03-25  9:26   ` Jean Pihet
2011-03-24  0:00 ` [PATCH/RFC 15/19] OMAP2+: voltage: move VC into struct voltagedomain, misc. renames Kevin Hilman
2011-03-24  0:00 ` [PATCH/RFC 16/19] OMAP2+: voltage: split out voltage processor (VP) code into new layer Kevin Hilman
2011-03-24  0:00 ` [PATCH/RFC 17/19] OMAP2+: voltage: VC: begin spliting out SoC specifics; start with i2c slave addr Kevin Hilman
2011-03-24  0:00 ` [PATCH/RFC 18/19] OMAP2+: VC: support PMICs with separate voltage and command registers Kevin Hilman
2011-03-24  0:00 ` [PATCH/RFC 19/19] OMAP2+: VC: add SoC-specific op for PMIC register addresses Kevin Hilman
2011-03-25  0:02 ` [PATCH/RFC 00/19] OMAP: voltage layer cleanup and restructure Kevin Hilman
2011-03-25  0:09   ` [PATCH] OMAP2+: VC: begin spliting out SoC specifics; start with i2c slave addr Kevin Hilman
2011-03-25  0:09   ` [PATCH] OMAP2+: VC: add SoC-specific op for PMIC register addresses Kevin Hilman
2011-03-25  9:31     ` Vishwanath Sripathy
2011-03-25 14:22       ` Kevin Hilman
2011-03-25 14:37   ` [PATCH/RFC 00/19] OMAP: voltage layer cleanup and restructure Cousson, Benoit
2011-03-25 23:02     ` Paul Walmsley
2011-03-26  0:20       ` Kevin Hilman
2011-03-25  8:58 ` Jean Pihet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hbnurp2.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=b-cousson@ti.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.