From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH 0/2] Fix hot-unplug: device removal while port in use Date: Wed, 16 Mar 2011 14:31:03 +1030 Message-ID: <877hbziuio.fsf@rustcorp.com.au> References: <20110311111628.GC8908@amit-x200.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110311111628.GC8908@amit-x200.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Amit Shah , Virtualization List Cc: markmc@redhat.com, "Michael S. Tsirkin" List-Id: virtualization@lists.linuxfoundation.org On Fri, 11 Mar 2011 16:46:28 +0530, Amit Shah wrote: > Ideally virtio_pci_release_dev() shouldn't be needed at all; all that > work can be moved to virtio_pci_remove(). virtio_pci_release_dev() > was added in 29f9f12e to curb a warning: > > virtio: add PCI device release() function > > Add a release() function for virtio_pci devices so as to avoid: > > Device 'virtio0' does not have a release() function, it is > broken and must be fixed > > > So we could have an empty release() function that does nothing, and > all of the current functionality be moved to virtio_pci_remove(), as > it was earlier. This should keep everyone happy. > > Is that fine? Greg K-H needs to be asked this question, I think. Cheers, Rusty.