Re: [PATCH v5 4/6] OMAP4: hwmod data: Add watchdog timer

[Kevin Hilman <khilman@deeprootsystems.com>]

"Cousson, Benoit" <b-cousson@ti.com> writes:

[...]

>>>>
>>>> As you mentioned, wd_timer3 in OMAP4 is an IVA3 watchdog timer.
>>>>
>>>> Also the current watchdog driver (omap_wdt.c) does not support more
>>>> than one watchdog timer. To add this support we need to first
>>>> redesign the driver code and then add wd_timer3 to the database.
>>>>
>>>> This patch series is intended to make watchdog driver to use
>>>> omap_hwmod APIs and PM runtime APIs. Driver modification to support
>>>> more than one watchdog timers can be taken up as a separate
>>>> activity later.
>>>
>>> No necessarily, even if you do not manage this watchdog, we do need to
>>> expose its hwmod in order to allow dspbridge/syslink to potentially
>>> enable or disable it.
>>
>> We also should expose it in the hwmod db so that it is initialized and
>> properly reset on init.
>
> Correct, so you do recommend to expose most hwmods as soon as they are
> not crashing at boot?  So far, the plan was to add only the ones
> validated with the drivers.

I think all hwmods for a given class should be posted at the same time.

If they are not validated with the driver, that is fine and the reason
should be clearly stated in the changelog.

Kevin