Re: [PATCH 04/20] Create platform_driver for each DSS HW IP

[Kevin Hilman <khilman@deeprootsystems.com>]

Guruswamy Senthilvadivu <svadivu@ti.com> writes:

> From: Senthilvadivu Guruswamy <svadivu@ti.com>
>
> Platform driver of DSS HW IP are to be registered in sequence before
> the omapdss platform driver is registered.
>
> Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
> ---
>  drivers/video/omap2/dss/core.c |  121 ++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 121 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
> index bcbb077..3b6a309 100644
> --- a/drivers/video/omap2/dss/core.c
> +++ b/drivers/video/omap2/dss/core.c
> @@ -707,6 +707,62 @@ static int omap_dss_resume(struct platform_device *pdev)
>  	return dss_resume_all_devices();
>  }
>  
> +/* DSS HW IP initialisation */
> +static int omap_dsshw_probe(struct platform_device *pdev)
> +{
> +	return 0;
> +}
> +
> +static int omap_dsshw_remove(struct platform_device *pdev)
> +{
> +	return 0;
> +}

It's not customary to create dummy, empty functions in one patch and
then fill them in later.  In this case, you create them here, move them
in PATCH 05/20, then fill them in later.

It would be easier to review if you created the platform_drivers when
needed.

Anyways, I'm not crazy about this approach, but Tomi can decide.


> +/* DISPC HW IP initialisation */
> +static int omap_dispchw_probe(struct platform_device *pdev)
> +{
> +	return 0;
> +}
> +
> +static int omap_dispchw_remove(struct platform_device *pdev)
> +{
> +	return 0;
> +}
> +
> +/* DSI1 HW IP initialisation */
> +static int omap_dsi1hw_probe(struct platform_device *pdev)
> +{
> +	return 0;
> +}
> +
> +static int omap_dsi1hw_remove(struct platform_device *pdev)
> +{
> +	return 0;
> +}
> +
> +/* RFBI HW IP initialisation */
> +static int omap_rfbihw_probe(struct platform_device *pdev)
> +{
> +	return 0;
> +}
> +
> +static int omap_rfbihw_remove(struct platform_device *pdev)
> +{
> +	return 0;
> +}
> +
> +/* VENC HW IP initialisation */
> +static int omap_venchw_probe(struct platform_device *pdev)
> +{
> +	return 0;
> +}
> +
> +static int omap_venchw_remove(struct platform_device *pdev)
> +{
> +	return 0;
> +}
> +
> +
>  static struct platform_driver omap_dss_driver = {
>  	.probe          = omap_dss_probe,
>  	.remove         = omap_dss_remove,
> @@ -719,6 +775,66 @@ static struct platform_driver omap_dss_driver = {
>  	},
>  };
>  
> +static struct platform_driver omap_dsshw_driver = {
> +	.probe          = omap_dsshw_probe,
> +	.remove         = omap_dsshw_remove,
> +	.shutdown	= NULL,
> +	.suspend	= NULL,
> +	.resume		= NULL,

Just leave them out if they're NULL since that is the default.

Kevin

> +	.driver         = {
> +		.name   = "dss",
> +		.owner  = THIS_MODULE,
> +	},
> +};
> +
> +static struct platform_driver omap_dispchw_driver = {
> +	.probe          = omap_dispchw_probe,
> +	.remove         = omap_dispchw_remove,
> +	.shutdown	= NULL,
> +	.suspend	= NULL,
> +	.resume		= NULL,
> +	.driver         = {
> +		.name   = "dss_dispc",
> +		.owner  = THIS_MODULE,
> +	},
> +};
> +
> +static struct platform_driver omap_dsi1hw_driver = {
> +	.probe          = omap_dsi1hw_probe,
> +	.remove         = omap_dsi1hw_remove,
> +	.shutdown	= NULL,
> +	.suspend	= NULL,
> +	.resume		= NULL,
> +	.driver         = {
> +		.name   = "dss_dsi1",
> +		.owner  = THIS_MODULE,
> +	},
> +};
> +
> +static struct platform_driver omap_rfbihw_driver = {
> +	.probe          = omap_rfbihw_probe,
> +	.remove         = omap_rfbihw_remove,
> +	.shutdown	= NULL,
> +	.suspend	= NULL,
> +	.resume		= NULL,
> +	.driver         = {
> +		.name   = "dss_rfbi",
> +		.owner  = THIS_MODULE,
> +	},
> +};
> +
> +static struct platform_driver omap_venchw_driver = {
> +	.probe          = omap_venchw_probe,
> +	.remove         = omap_venchw_remove,
> +	.shutdown	= NULL,
> +	.suspend	= NULL,
> +	.resume		= NULL,
> +	.driver         = {
> +		.name   = "dss_venc",
> +		.owner  = THIS_MODULE,
> +	},
> +};
> +
>  /* BUS */
>  static int dss_bus_match(struct device *dev, struct device_driver *driver)
>  {
> @@ -984,6 +1100,11 @@ static int __init omap_dss_init(void)
>  
>  static int __init omap_dss_init2(void)
>  {
> +	platform_driver_register(&omap_dsshw_driver);
> +	platform_driver_register(&omap_dispchw_driver);
> +	platform_driver_register(&omap_dsi1hw_driver);
> +	platform_driver_register(&omap_rfbihw_driver);
> +	platform_driver_register(&omap_venchw_driver);
>  	return platform_driver_register(&omap_dss_driver);
>  }