All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Monakhov <dmonakhov@openvz.org>
To: linux-ext4@vger.kernel.org
Subject: delalloc makes data=writeback safer
Date: Wed, 09 Jun 2010 16:19:27 +0400	[thread overview]
Message-ID: <877hm8jt4g.fsf@openvz.org> (raw)

Everybody know that writeback mode for ext3 is potentially result in
stale data in case of unclean umount. The same is true for ext4 with
nodelalloc.
But as far as i can see things is getting better in case of delalloc.
In case of delalloc we have following calltrace:
[writeback thread]
ext4_da_writepages
  journal_start()
  ext4_map_blocks() -> real block allocation
  mpage_da_submit_io() -> submit_bh() -> submit_bio()
  journal_stop()
So journal will be closed only after data was issued. 
And if journal->j_dev == journal->j_fs_dev (which is usually the case)
data will be serialized with metadata. So it looks like it is impassible
to see stale data even after unclean umount.

Do I miss something? May be this was already discussed before, 
if so please post a link to previous discussion.

             reply	other threads:[~2010-06-09 12:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-09 12:19 Dmitry Monakhov [this message]
2010-06-15 14:08 ` delalloc makes data=writeback safer Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hm8jt4g.fsf@openvz.org \
    --to=dmonakhov@openvz.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.