From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] RTC/pxa: remove unnecessary private ops->ioctl()
Date: Mon, 07 Jun 2010 10:47:05 +0200 [thread overview]
Message-ID: <877hmbcjqu.fsf@free.fr> (raw)
In-Reply-To: <4C0A5F53.6070600@gmail.com> (Wan ZongShun's message of "Sat, 05 Jun 2010 22:29:39 +0800")
Wan ZongShun <mcuos.com@gmail.com> writes:
> Please, do not implement private ops->ioctl() unless absolutely necessary.
> pxa series RTC driver's ioctl() is unnecessary, since RTC subsystem has implement
> the ioctl() very well,so we can only use the API of '.alarm_irq_enable' and
> '.update_irq_enable' to do enable irq action.
>
> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
This is not an urgent fix, but a cleanup. Whoever gets it in (Alessandro through
rtc tree, Eric through arm/pxa tree, or Andrew) is to be defined.
I would go for Alessandro, as he handles the RTC tree.
Cheers.
--
Robert
PS: Removed alsa-devel list, as this is not alsa material
next prev parent reply other threads:[~2010-06-07 8:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 14:29 [PATCH] RTC/pxa: remove unnecessary private ops->ioctl() Wan ZongShun
2010-06-05 14:29 ` Wan ZongShun
2010-06-07 8:47 ` Robert Jarzmik [this message]
2010-06-07 8:57 ` Wan ZongShun
2010-06-07 9:31 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hmbcjqu.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.