From: Dmitry Monakhov <dmonakhov@openvz.org>
To: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH 1/2] ext4: Do not allow retry alloc loop under open transaction
Date: Thu, 04 Feb 2010 15:06:31 +0300 [thread overview]
Message-ID: <877hqtdx2w.fsf@openvz.org> (raw)
In-Reply-To: <87wrytqlji.fsf@linux.vnet.ibm.com> (Aneesh Kumar K. V.'s message of "Thu, 04 Feb 2010 17:07:21 +0530")
"Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com> writes:
> On Wed, 03 Feb 2010 21:27:31 +0300, Dmitry Monakhov <dmonakhov@openvz.org> wrote:
>>
>> Some times we call ->write_begin() with opened journal
>> but write_begin() may internally call ext4_should_retry_alloc()
>> in case of ENOSPC, which result in deadlock.
>> This patch introduce new AOP_FLAG which should be tested on retry
>> alloc path.
>>
>
> Can you explain this further. We do a journal_stop before
> ext4_should_retry_alloc. So not sure about the deadlock.
move_extent_per_page
ext4_journal_start -> current->journal_info != NULL
->write_begin
ext4_journal_start
ext4_journal_stop
ext4_should_retry_alloc : here current->journal_info != NULL
Sorry i've missed the fact that ext4_should_retry_alloc() check
for current->journal_info and skip running transaction in that case.
Seems what this check was added long time ago, but i miss it.
So this patch is useless.
>
> -aneesh
prev parent reply other threads:[~2010-02-04 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 18:27 [PATCH 1/2] ext4: Do not allow retry alloc loop under open transaction Dmitry Monakhov
2010-02-04 11:37 ` Aneesh Kumar K. V
2010-02-04 12:06 ` Dmitry Monakhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hqtdx2w.fsf@openvz.org \
--to=dmonakhov@openvz.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.