All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Vikram Pandita <vikram.pandita@ti.com>
Cc: linux-omap@vger.kernel.org, "Menon, Nishanth" <nm@ti.com>
Subject: Re: [PATCH v2] omap: serial: fix coding style indentaion
Date: Thu, 07 Jan 2010 11:51:44 -0800	[thread overview]
Message-ID: <877hrty9pr.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1262893095-5091-1-git-send-email-vikram.pandita@ti.com> (Vikram Pandita's message of "Thu\,  7 Jan 2010 13\:38\:15 -0600")

Vikram Pandita <vikram.pandita@ti.com> writes:

> No logical code change
>
> Fix coding style indentaion as per checkpatch.pl
> Fix multi-line comment style reported by Nishanth Menon
>
> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> Cc: Menon, Nishanth <nm@ti.com>

Acked-by: Kevin Hilman <khilman@deeprootsystems.com>

> ---
>  arch/arm/mach-omap2/serial.c |   19 ++++++++++---------
>  1 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
> index 8c964be..837b347 100644
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> @@ -694,15 +694,16 @@ void __init omap_serial_init_port(int port)
>  		DEV_CREATE_FILE(dev, &dev_attr_sleep_timeout);
>  	}
>  
> -		/* omap44xx: Never read empty UART fifo
> -		 * omap3xxx: Never read empty UART fifo on UARTs
> -		 * with IP rev >=0x52
> -		 */
> -		if (cpu_is_omap44xx())
> -			uart->p->serial_in = serial_in_override;
> -		else if ((serial_read_reg(uart->p, UART_OMAP_MVER) & 0xFF)
> -				>= UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV)
> -			uart->p->serial_in = serial_in_override;
> +	/*
> +	 * omap44xx: Never read empty UART fifo
> +	 * omap3xxx: Never read empty UART fifo on UARTs
> +	 * with IP rev >=0x52
> +	 */
> +	if (cpu_is_omap44xx())
> +		uart->p->serial_in = serial_in_override;
> +	else if ((serial_read_reg(uart->p, UART_OMAP_MVER) & 0xFF)
> +			>= UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV)
> +		uart->p->serial_in = serial_in_override;
>  }
>  
>  /**
> -- 
> 1.6.6.rc0.66.ge160d
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-01-07 19:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-07 19:38 [PATCH v2] omap: serial: fix coding style indentaion Vikram Pandita
2010-01-07 19:51 ` Kevin Hilman [this message]
2010-01-11 23:36 ` [APPLIED] " Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hrty9pr.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=vikram.pandita@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.