Re: users of mod_timer_msec()

[Andi Kleen <andi@firstfloor.org>]

Arjan van de Ven <arjan@infradead.org> writes:

>  	emp->activity++;
>  	if (!timer_pending(&emp->timer))
> -		mod_timer(&emp->timer, jiffies + msecs_to_jiffies(10));
> +		mod_timer_msec(&emp->timer, 10);

... but your original patch does

+int mod_timer_msec(struct timer_list *timer, unsigned long delay_ms)
+{
+       return mod_timer(timer, msecs_to_jiffies(delay_ms));


That doesn't look equivalent.

mod_timer_msec should mod_timer_msec_plus_jiffies? 

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.