From: Pat Thoyts <patthoyts@users.sourceforge.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] gitk: Handle msysGit version during version comparisons
Date: 19 May 2009 11:38:08 +0100 [thread overview]
Message-ID: <877i0ds7hr.fsf@users.sourceforge.net> (raw)
In-Reply-To: <4A127306.6040904@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> writes:
>Johannes Schindelin venit, vidit, dixit 19.05.2009 10:43:
>> Hi,
>>
>> On Mon, 18 May 2009, Pat Thoyts wrote:
>>
>>>
>>> msysGit generates version strings with text appended which cannot
>>> be used with vcompare. Limit git_version to the first three digits
>>> which are the real git version.
>>>
>>> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
>>
>> Is that indent intentional?
>>
>> Ciao,
>> Dscho
>
>It is clearly indentional :)
>
>[During my git beginnings, the standard output format of git log made me
>believe I should format commit message bodies like that, too.]
It was intentional and the above followup is why. Evidently I should
not do so in the future.
--
Pat Thoyts http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD
prev parent reply other threads:[~2009-05-19 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 21:46 [PATCH] gitk: Handle msysGit version during version comparisons Pat Thoyts
2009-05-18 22:57 ` Paul Mackerras
2009-05-19 8:43 ` Johannes Schindelin
2009-05-19 8:51 ` Michael J Gruber
2009-05-19 10:38 ` Pat Thoyts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877i0ds7hr.fsf@users.sourceforge.net \
--to=patthoyts@users.sourceforge.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.