From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Smith Subject: Re: [RFC v14-rc3][PATCH 36/36] Stub implementation of IPC namespace c/r Date: Mon, 13 Apr 2009 07:23:37 -0700 Message-ID: <877i1oeiom.fsf@caffeine.danplanet.com> References: <1239107264-21775-1-git-send-email-orenl@cs.columbia.edu> <1239107264-21775-37-git-send-email-orenl@cs.columbia.edu> <20090409212939.GD5115@us.ibm.com> <49E163FC.4080306@cs.columbia.edu> <20090413141022.GA13007@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090413141022.GA13007-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> (Serge E. Hallyn's message of "Mon, 13 Apr 2009 09:10:22 -0500") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Dave Hansen List-Id: containers.vger.kernel.org SH> But actually I think it's better if you move that into an SH> appropriately named little static inline helper (commented). Then SH> the reader can verify it once separately, and then ignore how it SH> works while verifying the surrounding code. Not just here but, SH> other places where you do this. Seconded-by: Dan Smith :) -- Dan Smith IBM Linux Technology Center email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org