All of lore.kernel.org
 help / color / mirror / Atom feed
From: Otavio Salvador <otavio@ossystems.com.br>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] New package: siproxd
Date: Mon, 23 Mar 2009 05:26:28 -0300	[thread overview]
Message-ID: <877i2g63wr.fsf@neumann.lab.ossystems.com.br> (raw)
In-Reply-To: <200902171525.28995.khimov@altell.ru> (Roman I. Khimov's message of "Tue, 17 Feb 2009 15:25:28 +0300")

Roman I Khimov <khimov@altell.ru> writes:

> Otavio Salvador:

[...]


[...]

> +do_install_append() {
> +	mv ${D}/${sysconfdir}/siproxd.conf{.example,}
> +}

[...]


This is bashims, it would be better to use expanded commands
instead. Except from it, it looks OK for me.

Mind to fix it? 

-- 
Otavio Salvador                  O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br



  parent reply	other threads:[~2009-03-23  8:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13 21:35 [PATCH] New package: siproxd Roman I Khimov
2009-02-14  6:30 ` Marcin Juszkiewicz
2009-02-14  8:34   ` Koen Kooi
2009-02-14 14:15   ` Roman I Khimov
2009-02-15 18:23     ` Otavio Salvador
2009-02-15 21:13       ` Tom Rini
2009-02-16  1:09         ` Otavio Salvador
2009-02-16  9:28           ` Roman I Khimov
2009-02-16 10:22             ` Marcin Juszkiewicz
2009-02-16 12:21             ` Otavio Salvador
2009-02-17 12:25       ` Roman I Khimov
2009-02-27  4:34         ` Khem Raj
2009-03-25 20:21           ` Roman I Khimov
2009-03-23  8:26         ` Otavio Salvador [this message]
2009-03-23 18:37           ` Roman I Khimov
2009-03-23 20:25             ` Otavio Salvador
2009-03-24  9:47               ` Koen Kooi
2009-03-26 14:56           ` Roman I Khimov
2009-04-21 20:17             ` Roman I Khimov
2009-04-21 20:29               ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877i2g63wr.fsf@neumann.lab.ossystems.com.br \
    --to=otavio@ossystems.com.br \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.