From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KUivK-00020X-P7
	for mharc-grub-devel@gnu.org; Sun, 17 Aug 2008 10:08:02 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KUivI-00020H-D8
	for grub-devel@gnu.org; Sun, 17 Aug 2008 10:08:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KUivG-000204-La
	for grub-devel@gnu.org; Sun, 17 Aug 2008 10:07:59 -0400
Received: from [199.232.76.173] (port=36625 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KUivG-000201-Gj
	for grub-devel@gnu.org; Sun, 17 Aug 2008 10:07:58 -0400
Received: from smtp-vbr9.xs4all.nl ([194.109.24.29]:3911)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mgerards@xs4all.nl>) id 1KUivG-0001S1-5z
	for grub-devel@gnu.org; Sun, 17 Aug 2008 10:07:58 -0400
Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net
	[145.99.174.249])
	by smtp-vbr9.xs4all.nl (8.13.8/8.13.8) with ESMTP id m7HE7u2v056792
	for <grub-devel@gnu.org>; Sun, 17 Aug 2008 16:07:57 +0200 (CEST)
	(envelope-from mgerards@xs4all.nl)
From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <20080817130119.GA22343@pina.cat>
Mail-Copies-To: mgerards@xs4all.nl
Date: Sun, 17 Aug 2008 16:12:02 +0200
In-Reply-To: <20080817130119.GA22343@pina.cat> (Carles Pina i. Estany's
	message of "Sun, 17 Aug 2008 15:01:19 +0200")
Message-ID: <877iaf20jx.fsf@xs4all.nl>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: by XS4ALL Virus Scanner
X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9
Subject: Re: [PATCH] Replace magic numbers by constants
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Aug 2008 14:08:00 -0000

Hi,

Carles Pina i Estany <carles@pina.cat> writes:

> When I did the Home/End keys patch I noticied that in normal/menu.c
> there was some magic numbers (and some constants was already defined, in
> include/grub/term.h (actually, reading the ChangeLog was committed by
> Robert Millan on 2008-02-05)
>
> I'm sending a patch to change the magic numbers by constants.
>
> ChangeLog:
> --------
> 2008-08-17  Carles Pina i Estany  <carles@pina.cat>
>
> 	* menu/normal.c (run_menu): Change magic numbers by constants.

Can you be more specific about what you replace?

Thanks,
Marco