From: Andi Kleen <andi@firstfloor.org>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: invalidate caches before going into suspend
Date: Wed, 13 Aug 2008 21:39:28 +0200 [thread overview]
Message-ID: <877iak1z7z.fsf@basil.nowhere.org> (raw)
In-Reply-To: <200808131141.18003.mark.langsdorf@amd.com> (Mark Langsdorf's message of "Wed, 13 Aug 2008 11:41:17 -0500")
Mark Langsdorf <mark.langsdorf@amd.com> writes:
> @@ -93,11 +93,11 @@ static inline void play_dead(void)
> static inline void play_dead(void)
> {
> idle_task_exit();
> - wbinvd();
> mb();
> /* Ack it */
> __get_cpu_var(cpu_state) = CPU_DEAD;
>
> + wbinvd();
You should put the mb() (or just a barrier()) directly above the wbinvd(),
otherwise the compiler is free to reorder this behind your back again
and move the store down after the wbinvd.
-Andi
prev parent reply other threads:[~2008-08-13 19:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 16:41 invalidate caches before going into suspend Mark Langsdorf
2008-08-13 16:47 ` Ingo Molnar
2008-08-13 16:53 ` H. Peter Anvin
2008-08-13 17:01 ` Ingo Molnar
2008-08-13 17:28 ` H. Peter Anvin
2008-08-13 17:35 ` Ingo Molnar
2008-08-13 17:37 ` H. Peter Anvin
2008-08-13 17:09 ` Mark Langsdorf
2008-08-13 17:17 ` Linus Torvalds
2008-08-13 17:30 ` Mark Langsdorf
2008-08-13 17:52 ` Ingo Molnar
2008-08-13 18:33 ` [PATCH](retry 2) " Mark Langsdorf
2008-08-13 18:42 ` Arjan van de Ven
2008-08-13 18:47 ` Langsdorf, Mark
2008-08-13 21:32 ` Arjan van de Ven
2008-08-14 13:45 ` [PATCH](retry 3) " Mark Langsdorf
2008-08-14 13:49 ` Ingo Molnar
2008-08-14 14:00 ` Arjan van de Ven
2008-08-14 14:11 ` [PATCH](retry 4) " Mark Langsdorf
2008-08-15 12:04 ` Ingo Molnar
2008-08-13 17:38 ` Ingo Molnar
2008-08-13 19:39 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877iak1z7z.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.