From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KOs1Z-0000Bp-0a for mharc-grub-devel@gnu.org; Fri, 01 Aug 2008 06:38:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOs1X-0000Ax-72 for grub-devel@gnu.org; Fri, 01 Aug 2008 06:38:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOs1U-0000A9-Ll for grub-devel@gnu.org; Fri, 01 Aug 2008 06:38:14 -0400 Received: from [199.232.76.173] (port=38121 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOs1U-0000A4-Gf for grub-devel@gnu.org; Fri, 01 Aug 2008 06:38:12 -0400 Received: from smtp-vbr7.xs4all.nl ([194.109.24.27]:4380) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KOs1T-00052L-NW for grub-devel@gnu.org; Fri, 01 Aug 2008 06:38:12 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr7.xs4all.nl (8.13.8/8.13.8) with ESMTP id m71Ac3sq072940 for ; Fri, 1 Aug 2008 12:38:08 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1217459965.26275.14.camel@fz-deb.local> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 01 Aug 2008 12:40:17 +0200 In-Reply-To: <1217459965.26275.14.camel@fz-deb.local> (Felix Zielcke's message of "Thu, 31 Jul 2008 01:19:25 +0200") Message-ID: <877ib1hvce.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] skip over invalid BSD partitions X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2008 10:38:15 -0000 Felix Zielcke writes: > On invalid BSD partitions partmap/pc.c stops with reading the partitons, > so grub doestn't know anything about the ones behind it. > Attached patch fixes this and displays also the partition number not > only the invalid magic it encounters > > 2008-07-31 Felix Zielcke > > * partmap/pc.c (pc_partition_map_iterate): Skip over invalid BSD partitions > or if there's no space for the disk label and print the partition number on a > invalid magic When does this occur? > Index: partmap/pc.c > =================================================================== > --- partmap/pc.c (Revision 1753) > +++ partmap/pc.c (Arbeitskopie) > @@ -160,9 +160,11 @@ > { > /* Check if the BSD label is within the DOS partition. */ > if (p.len <= GRUB_PC_PARTITION_BSD_LABEL_SECTOR) > - return grub_error (GRUB_ERR_BAD_PART_TABLE, > - "no space for disk label"); > - > + { > + grub_error (GRUB_ERR_BAD_PART_TABLE, > + "no space for disk label"); > + continue; > + } If you continue as no error occured, why do you throw an error? -- Marco