From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KET2I-0002yx-5V for mharc-grub-devel@gnu.org; Thu, 03 Jul 2008 13:56:02 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KET2F-0002wj-TV for grub-devel@gnu.org; Thu, 03 Jul 2008 13:55:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KET2F-0002vx-3f for grub-devel@gnu.org; Thu, 03 Jul 2008 13:55:59 -0400 Received: from [199.232.76.173] (port=40027 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KET2E-0002vd-Se for grub-devel@gnu.org; Thu, 03 Jul 2008 13:55:58 -0400 Received: from smtp-vbr4.xs4all.nl ([194.109.24.24]:2849) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KET2E-0006uX-FC for grub-devel@gnu.org; Thu, 03 Jul 2008 13:55:58 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr4.xs4all.nl (8.13.8/8.13.8) with ESMTP id m63Htu63052982 for ; Thu, 3 Jul 2008 19:55:57 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080614193028.GB840@thorin> <20080615132552.GA17222@thorin> <20080701155427.GA6985@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Thu, 03 Jul 2008 20:04:18 +0200 In-Reply-To: (bean123ch@gmail.com's message of "Wed, 2 Jul 2008 15:39:49 +0800") Message-ID: <877ic27skd.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] Save/Load environment variable support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2008 17:56:00 -0000 Bean writes: > On Tue, Jul 1, 2008 at 11:54 PM, Robert Millan wrote: >> On Mon, Jun 30, 2008 at 09:06:28PM +0800, Bean wrote: >>> Hi, >>> >>> This is the new patch, some changes: >>> >>> 1, envblk.h, remove GRUB_ENVBLK_RDIR and the like, they're not needed >>> in this patch. >>> 2, util/envblk.c, use grub_* function for string manipulation. >>> 3, commands/loadenv.c, use grub_disk_read/grub_disk_write to >>> read/write disk, the problem of lower level api is that they don't >>> update the cache. >>> >>> If there is no problem, I'd like to commit this soon. >> >> Fine with me! > > Committed. Great! Can you explain how it works? -- Marco