From: Peter Korsgaard <jacmet@sunsite.dk>
To: jeff@garzik.org, netdev@vger.kernel.org
Subject: [PATCH] dm9601: Fix multicast hash table handling
Date: Fri, 28 Mar 2008 22:25:29 +0100 [thread overview]
Message-ID: <877ifmfsmu.fsf@macbook.be.48ers.dk> (raw)
The loop forgot to walk the net->mc_list list, so only the first
multicast address was programmed into the hash table.
---
Jeff, I would like to get this patch in 2.6.25 if possible.
drivers/net/usb/dm9601.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c
index 0343b00..01660f6 100644
--- a/drivers/net/usb/dm9601.c
+++ b/drivers/net/usb/dm9601.c
@@ -354,7 +354,7 @@ static void dm9601_set_multicast(struct net_device *net)
struct dev_mc_list *mc_list = net->mc_list;
int i;
- for (i = 0; i < net->mc_count; i++) {
+ for (i = 0; i < net->mc_count; i++, mc_list = mc_list->next) {
u32 crc = ether_crc(ETH_ALEN, mc_list->dmi_addr) >> 26;
hashes[crc >> 3] |= 1 << (crc & 0x7);
}
--
1.5.4.4
--
Bye, Peter Korsgaard
next reply other threads:[~2008-03-28 21:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 21:25 Peter Korsgaard [this message]
2008-03-29 1:53 ` [PATCH] dm9601: Fix multicast hash table handling Jeff Garzik
2008-03-29 9:23 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2008-03-18 22:16 Peter Korsgaard
2008-03-26 3:20 ` Jeff Garzik
2008-03-26 3:33 ` Jeff Garzik
2008-03-26 7:51 ` Peter Korsgaard
2008-03-26 7:34 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ifmfsmu.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.