Re: [PATCH] allow user-configurable menucolor

[Jeroen Dekkers <jeroen@vrijschrift.org>]

At Sun, 6 Jan 2008 00:42:40 +0100,
Robert Millan wrote:
> 
> On Sat, Jan 05, 2008 at 10:45:46PM +0100, Jeroen Dekkers wrote:
> > You should actually also include grub/env.h if you use struct
> > grub_env_var in the prototypes.
> 
> Uhm, I included it in normal/color.c to satisfy the dependencies:
> 
> normal/color.c:#include <grub/env.h>
> normal/color.c:grub_env_write_color_normal (struct grub_env_var *var __attribute__ ((unused)),
> normal/color.c:grub_env_write_color_highlight (struct grub_env_var *var __attribute__ ((unused)),
> 
> but your idea seems better.  I suppose we can remove it from there now?

Yes, but normal.h is included by lots of other files that don't always
include env.h before they include normal.h.
 
> Btw, nice to see you around here.  Do you have any news about the CD-ROM
> GSoC ?  I looked at the tarball from google.com, but CD access seems
> unfinished (I couldn't access the CD neither in qemu nor in real hw).

It should work, but I didn't have the time to test it at the end of
the summer. I guess you can simply mail Alex if you have any
questions...


Jeroen Dekkers