From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JBTl4-0000d2-PN for mharc-grub-devel@gnu.org; Sun, 06 Jan 2008 06:33:38 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JBTl1-0000XX-VR for grub-devel@gnu.org; Sun, 06 Jan 2008 06:33:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JBTkz-0000TJ-VD for grub-devel@gnu.org; Sun, 06 Jan 2008 06:33:34 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JBTkz-0000Sk-Mv for grub-devel@gnu.org; Sun, 06 Jan 2008 06:33:33 -0500 Received: from neonescio.viaisn.org ([82.94.249.43]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JBTkz-0006Ci-CB for grub-devel@gnu.org; Sun, 06 Jan 2008 06:33:33 -0500 Received: from dijkstra.dekkers.cx ([2001:960:7a0:0:213:d4ff:fe9c:2487] ident=Debian-exim) by neonescio.viaisn.org with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32 CV=0) (Exim 4.63 #1) id 1JBTkw-0002YG-Tz for grub-devel@gnu.org; Sun, 06 Jan 2008 12:33:31 +0100 Received: from localhost ([127.0.0.1] helo=dijkstra.dekkers.cx ident=jeroen) by dijkstra.dekkers.cx with esmtp (Exim 4.68) (envelope-from ) id 1JBTkv-0001Hk-JU for grub-devel@gnu.org; Sun, 06 Jan 2008 12:33:29 +0100 Date: Sun, 06 Jan 2008 12:33:29 +0100 Message-ID: <877iin2np2.wl@dekkers.cx> From: Jeroen Dekkers To: The development of GRUB 2 In-Reply-To: <20080105234240.GA7078@thorin> References: <20080101124728.GA30417@thorin> <200801030042.01855.okuji@enbug.org> <20080103010414.GC6843@thorin> <20080103153533.GA24992@thorin> <878x342bg5.wl@dekkers.cx> <20080105234240.GA7078@thorin> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.7 Emacs/22.1 (x86_64-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] allow user-configurable menucolor X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jan 2008 11:33:36 -0000 At Sun, 6 Jan 2008 00:42:40 +0100, Robert Millan wrote: > > On Sat, Jan 05, 2008 at 10:45:46PM +0100, Jeroen Dekkers wrote: > > You should actually also include grub/env.h if you use struct > > grub_env_var in the prototypes. > > Uhm, I included it in normal/color.c to satisfy the dependencies: > > normal/color.c:#include > normal/color.c:grub_env_write_color_normal (struct grub_env_var *var __attribute__ ((unused)), > normal/color.c:grub_env_write_color_highlight (struct grub_env_var *var __attribute__ ((unused)), > > but your idea seems better. I suppose we can remove it from there now? Yes, but normal.h is included by lots of other files that don't always include env.h before they include normal.h. > Btw, nice to see you around here. Do you have any news about the CD-ROM > GSoC ? I looked at the tarball from google.com, but CD access seems > unfinished (I couldn't access the CD neither in qemu nor in real hw). It should work, but I didn't have the time to test it at the end of the summer. I guess you can simply mail Alex if you have any questions... Jeroen Dekkers