From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1EtU2K-0005Op-Uh for mharc-grub-devel@gnu.org; Mon, 02 Jan 2006 13:04:01 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EtU2J-0005OI-Ul for grub-devel@gnu.org; Mon, 02 Jan 2006 13:04:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EtU2I-0005Nf-Ai for grub-devel@gnu.org; Mon, 02 Jan 2006 13:03:59 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EtU2H-0005NS-Vb for grub-devel@gnu.org; Mon, 02 Jan 2006 13:03:58 -0500 Received: from [194.109.24.28] (helo=smtp-vbr8.xs4all.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EtU3N-000308-5G for grub-devel@gnu.org; Mon, 02 Jan 2006 13:05:05 -0500 Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by smtp-vbr8.xs4all.nl (8.13.3/8.13.3) with ESMTP id k02I2HmR016785 for ; Mon, 2 Jan 2006 19:02:18 +0100 (CET) (envelope-from mgerards@xs4all.nl) Mail-Copies-To: mgerards@xs4all.nl To: The development of GRUB 2 References: <154544dd1923da83d45950b5eeda53e3@penguinppc.org> <87fyo65yip.fsf@xs4all.nl> <5a9811b68c26fe828d35b0de819dc6a7@penguinppc.org> From: Marco Gerards Date: Mon, 02 Jan 2006 19:02:17 +0100 In-Reply-To: <5a9811b68c26fe828d35b0de819dc6a7@penguinppc.org> (Hollis Blanchard's message of "Mon, 2 Jan 2006 11:50:31 -0600") Message-ID: <877j9i5x06.fsf@xs4all.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner Subject: Re: [patch] rough Mac OS X loader X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2006 18:04:00 -0000 Hollis Blanchard writes: >>> +void EXPORT_FUNC (grub_jump) (unsigned long text, unsigned long >>> stack, >>> + unsigned long arg1, unsigned long arg2); >> >> Shouldn't a pointer be used here? > > Used where? For grub_jump's arguments. It jumps to some address, right? >>> +/* BootX, the Mac OS X bootloader, is an XCOFF executable with a >>> CHRP script >>> + * prepended to it. We skip the script and load the XCOFF file. */ >> >> What is in this script? Are you completely sure it can be skipped? > > It loads the XCOFF into memory. Yes. Ah! :) >>> +static grub_err_t >>> +grub_macosx_release_mem (void) >>> +{ >>> + /* XXX write me */ >> >> I assume you encountered a bug in the firmware while writing this >> function? :-) > > No, just haven't written it yet. :) I think the XCOFF sections in > BootX are contiguous though, so if that's true it should not be > difficult. Oh, ok. In that case please add it to the to do list after this patch is committed. >>> +/* Find NULL-terminated `needle' in non-terminated `haystack'. */ >>> +static void * >>> +grub_memstr (void *haystack, int len, char *needle) >> >> Perhaps it is better to move this to kern/misc.c? > > I had that thought, but "memstr" is not a standard POSIX function so I > wasn't sure. It's looks like a useful function to me. We can always move it back if it turns out no one uses it... Thanks, Marco