From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1EbP1b-0004q8-1L for mharc-grub-devel@gnu.org; Sun, 13 Nov 2005 16:04:31 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EbP1Z-0004nI-IB for grub-devel@gnu.org; Sun, 13 Nov 2005 16:04:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EbP1X-0004ko-QO for grub-devel@gnu.org; Sun, 13 Nov 2005 16:04:29 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EbP1W-0004kb-GA for grub-devel@gnu.org; Sun, 13 Nov 2005 16:04:27 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EbP1W-0006FK-82 for grub-devel@gnu.org; Sun, 13 Nov 2005 16:04:26 -0500 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 944AE8644 for ; Sun, 13 Nov 2005 22:04:25 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 05173-09 for ; Sun, 13 Nov 2005 22:04:24 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id C3F6A855D for ; Sun, 13 Nov 2005 22:04:24 +0100 (CET) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 77B19C047 for ; Sun, 13 Nov 2005 22:04:24 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <200511131915.12348.T.E.Baldwin99@members.leeds.ac.uk> From: Marco Gerards Date: Sun, 13 Nov 2005 22:04:25 +0100 In-Reply-To: <200511131915.12348.T.E.Baldwin99@members.leeds.ac.uk> (Timothy Baldwin's message of "Sun, 13 Nov 2005 19:15:11 +0000") Message-ID: <877jbcgsyu.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: symbol.h fix for ARM X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Nov 2005 21:04:29 -0000 Timothy Baldwin writes: > In ARM GAS syntax "@" marks the start of comment, which breaks symbol.h. I choose > double quotes as a replacement as they can't be used to start comments. > > 2005-11-13 Timothy Baldwin > > Fix symbol.h for ARM. > > * include/grub/symbol.h: (FUNCTION): Use double quotes > instead of "@" which marks the start of a comment on ARM. > (VARIABLE): Likewise. Have you tested if other archs keep working with this patch applied? -- Marco