From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1DM7y4-0004bp-L1 for mharc-grub-devel@gnu.org; Thu, 14 Apr 2005 13:17:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DM7y3-0004bC-8C for grub-devel@gnu.org; Thu, 14 Apr 2005 13:17:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DM7xx-0004YY-4E for grub-devel@gnu.org; Thu, 14 Apr 2005 13:17:22 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DM7xu-0004Xd-MY for grub-devel@gnu.org; Thu, 14 Apr 2005 13:17:20 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DM7vF-0006SV-Ff for grub-devel@gnu.org; Thu, 14 Apr 2005 13:14:33 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id E0546861E for ; Thu, 14 Apr 2005 19:13:33 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 20474-06 for ; Thu, 14 Apr 2005 19:13:31 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 84D4385CE for ; Thu, 14 Apr 2005 19:13:31 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 4955DC045 for ; Thu, 14 Apr 2005 19:13:31 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050414023823.GA24293@miracle> From: Marco Gerards Date: Thu, 14 Apr 2005 19:13:32 +0200 In-Reply-To: <20050414023823.GA24293@miracle> (Hollis Blanchard's message of "Wed, 13 Apr 2005 21:38:23 -0500") Message-ID: <877jj5ffib.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [patch] set prefix on PPC X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2005 17:17:27 -0000 Hollis Blanchard writes: > Marco, I believe I addressed all your comments in my mail on 23 Feb > 2005. I have implemented your suggestions, with the exception of > checking the device node property lengths, as this requires modifying > many callers elsewhere in the code. Ok. I will test the patch on both of my machines to see if it works for me. > I will commit this in a couple days if I don't hear any complaints. Ok. > Index: loader/powerpc/ieee1275/linux.c > =================================================================== > RCS file: /cvsroot/grub/grub2/loader/powerpc/ieee1275/linux.c,v > retrieving revision 1.6 > diff -u -p -r1.6 linux.c > --- loader/powerpc/ieee1275/linux.c 14 Feb 2005 18:41:33 -0000 1.6 > +++ loader/powerpc/ieee1275/linux.c 14 Apr 2005 02:57:01 -0000 > @@ -55,7 +55,7 @@ grub_linux_boot (void) > /* Set the command line arguments. */ > grub_ieee1275_set_property (chosen, "bootargs", linux_args, > grub_strlen (linux_args) + 1, &actual); > - > + > /* Boot the kernel. */ > linuxmain = (kernel_entry_t) linux_addr; > linuxmain ((void *) initrd_addr, initrd_size, grub_ieee1275_entry_fn, 0, 0); Can you fix this? :) -- Marco