From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1CHQgh-0004nr-Fg for mharc-grub-devel@gnu.org; Tue, 12 Oct 2004 13:43:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CHQgf-0004nS-FL for grub-devel@gnu.org; Tue, 12 Oct 2004 13:43:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CHQgf-0004nG-0y for grub-devel@gnu.org; Tue, 12 Oct 2004 13:43:49 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CHQge-0004nD-Td for grub-devel@gnu.org; Tue, 12 Oct 2004 13:43:48 -0400 Received: from [193.45.208.6] (helo=griffin.skarpodata.com) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1CHQZa-0007WM-Fw for grub-devel@gnu.org; Tue, 12 Oct 2004 13:36:31 -0400 Received: from localhost.localdomain (183.201.216.81.s-s.siw.siwnet.net [81.216.201.183]) by griffin.skarpodata.com (8.12.10/8.12.10) with ESMTP id i9CJ1E8c015218 for ; Tue, 12 Oct 2004 21:01:14 +0200 To: The development of GRUB 2 References: <6C8637B2-1C58-11D9-AD2F-000A95A0560C@penguinppc.org> From: Johan Rydberg Date: Tue, 12 Oct 2004 19:37:46 +0200 In-Reply-To: <6C8637B2-1C58-11D9-AD2F-000A95A0560C@penguinppc.org> (Hollis Blanchard's message of "Tue, 12 Oct 2004 09:10:08 -0500") Message-ID: <877jpvj0r9.fsf@night.trouble.net> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: ChangeLogs? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Oct 2004 17:43:49 -0000 Hollis Blanchard writes: > ChangeLog files are new to me, so could somebody help explain them? > (Yes I've read the GNU Coding Standards.) > > It seems to me that the ChangeLog is an anachronism born in a time > before source control systems, and a poor substitute for the actual > patch. The GCS does not explain the role of the ChangeLog file in the > context of a system like CVS, and I find that to be a glaring > omission. Why would you want a ChangeLog when CVS can tell you what > *really* happened? ChangeLogs is must like you said, an inheritance from the time when VC systems wasn't wide spread. But it still fills an function. CVS, and before that, RCS, are both file-based VC systems. By adding an ChangeLog entry describing all changes you get the _feeling_ of a changeset / patchset based VC system. This is also the reason why you describe _what_ changed, and not _why_ it changed. Another reason for having ChangeLogs is that it is easier to read an ChangeLog than browsing through large amounts of patches. Say that person A commits a patch, or patchset. Then persons B, C and D commits other changes. And then it's time for you to commit your patch, but suddenly nothing works. You get a segmentation error in the function "foobar". What to do? Well, the simplest thing is to bring up the ChangeLog, search for "foobar", and see if any of these changes could possibly be the reason for your troubles. A third reason is that it at times can be hard to interpret patches, even if they are in unidiff format. Summary: It is easy to read ChangeLogs. But ChangeLogs will most likely go away, or at least change, when changeset based VC system (GNU Arch, for example) gets more wide spread usage. > I guess my real problem is the level of detail in the ChangeLog: way > too much, or way too little. If you want that much detail, read the > patch. "New variable" doesn't give you enough detail anyways: What > type is it? Where is it initialized? Where is it used? Or it gives you > too much detail: maybe you just want to know that there's a firmware > bug in certain systems that we work around by setting a flag so later > code knows to avoid it. Remember that you should only describe _what_ you have changed. If you want to clearify something, put it in a comment in the source. Just my thoughts. ~j