From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1BbiMN-0006px-MR for mharc-grub-devel@gnu.org; Sat, 19 Jun 2004 12:06:27 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BbiMN-0006ps-2j for grub-devel@gnu.org; Sat, 19 Jun 2004 12:06:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BbiML-0006pg-EH for grub-devel@gnu.org; Sat, 19 Jun 2004 12:06:26 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BbiML-0006pd-Az for grub-devel@gnu.org; Sat, 19 Jun 2004 12:06:25 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BbiKr-0008Ok-CR for grub-devel@gnu.org; Sat, 19 Jun 2004 12:04:53 -0400 Received: from localhost (charlie.han.nl [145.74.66.9]) by mail-cn.han.nl (Postfix) with ESMTP id C503E8A83 for ; Sat, 19 Jun 2004 18:01:46 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by localhost (charlie.han.nl [145.74.66.9]) (amavisd-new, port 10024) with ESMTP id 10347-01 for ; Sat, 19 Jun 2004 18:01:45 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id DF331897B for ; Sat, 19 Jun 2004 18:01:44 +0200 (CEST) Received: from marco.marco-g.com (a82-92-27-129.adsl.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 7CDE0C048 for ; Sat, 19 Jun 2004 17:01:43 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20040615113103.GA4639@artax.karlin.mff.cuni.cz> <874qp9dled.fsf@marco.marco-g.com> <20040618191411.GA30179@artax.karlin.mff.cuni.cz> <200406191705.01343.okuji@enbug.org> From: Marco Gerards Date: Sat, 19 Jun 2004 18:01:45 +0200 In-Reply-To: <200406191705.01343.okuji@enbug.org> (Yoshinori K. Okuji's message of "Sat, 19 Jun 2004 17:05:00 +0200") Message-ID: <877ju3pmdy.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new@vscan-cn.han.nl Subject: Re: Autoloading WAS: normal/cmdline bug & patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jun 2004 16:06:27 -0000 "Yoshinori K. Okuji" writes: > for each loaded filesystem module: > try the filesystem with a specified partition/disk > return if successful > for each non-loaded filesystem module: > load the filesystem module > try the filesystem > return if successful > unload the filesystem module This is like what I proposed, with the difference of unloading the module. I don't think the memory usage is *that* high. For example, there are 15 filesystems that should be tried. The filesystems that we have now (ext2, fat, ufs and minixfs) are all about 4KB. I want to make some changes (sharing code) so that will become smaller, but there will be more complex filesystem. Let's assume for now the average filesystem module will be 5KB. In that case (15*5) 75KB will be used as max. To me that looks like low memory usage, less than reloading those modules all the time. For the apple it is no problem to use a lot of memory. I don't think there are problems for the pc, unless we have to use <1MB. So I think it is not needed to unload those filesystems and that keeping those loaded will only boost performance. If it is required we can use (as Tomas proposed, IIRC) a user setable variable to indicate if modules should be unloaded or not. > I prefer this to C, because I've seen the command "mount" in GNU/Linux > not maintained all the time very well. I guess this is because the > author of code for a filesystem may not use "mount -t auto ..." with > the filesystem. This would happen even in GRUB, since you wouldn't > notice that the autoload of your filesystem module is broken, if you > preload it in core or explicitly load it manually or in a config file. I agree. -- Marco