From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0647E606A31C for ; Tue, 17 Nov 2026 18:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XP+D93jm; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=S1m4Mqm+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=n46MKOyh; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=zUEA0GCx Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xTNs8-0007Tk-VO; Tue, 17 Nov 2026 13:25:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xTNru-0007NN-5i for qemu-devel@nongnu.org; Tue, 17 Nov 2026 13:25:28 -0500 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xTNrs-0003xK-LF for qemu-devel@nongnu.org; Tue, 17 Nov 2026 13:25:21 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 13E6622018; Tue, 17 Nov 2026 18:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1794939918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NHYpUYUmXZCXxnyrrRYBQOpZVKZEqTLpDXapDLqsiQ4=; b=XP+D93jmyk0zFbH4PidBxjgTr7WbVLJsCLInn1LYqh7kp0wk/976/WL562NzT4zkdkfI9b SFAP54ZC2nRFIjL++5X03u87IsRoZt7j+1BUFOI8Cu5xdfqktoBKUDAjBGLcSh4BUR3kWJ 6EHQhoHIc9S3Pc6a3/ngvai1zslZE6c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1794939918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NHYpUYUmXZCXxnyrrRYBQOpZVKZEqTLpDXapDLqsiQ4=; b=S1m4Mqm+AiShohiGK4RsS5rfN1kT0fbuYJE6Ml/gBbAt3OV0MzfSuOPViWKfjdCuLo44VX hPk7DlvyruAiReDA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=n46MKOyh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zUEA0GCx DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1794939917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NHYpUYUmXZCXxnyrrRYBQOpZVKZEqTLpDXapDLqsiQ4=; b=n46MKOyhWIJy0S373lZlHN7qql+alzPJbpr/2Kb6JWI5WH5IlyKGHj8CdtBNlk2wNZuatB HVstpoJy2MpbwH1ID3jVfLo0IA/lbZUGZyPhKvFK1BWZCY1SRJMU951wShoEx/6d6JLYeA mb+sMz+Bmwvi9N4/R6vKkdkSv7T8PB4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1794939917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NHYpUYUmXZCXxnyrrRYBQOpZVKZEqTLpDXapDLqsiQ4=; b=zUEA0GCxMxjlDaLChKeGf+UmUjiIp2BuUFg+npSLgSO3lZx7xhTUw6Afypwy25Csg6Yc95 en9kzFe5nczn0mAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6FBB613302; Tue, 17 Nov 2026 18:25:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qcKwAgyc/Gr8NAAAD6G6ig (envelope-from ); Tue, 17 Nov 2026 18:25:16 +0000 From: Fabiano Rosas To: "Denis V. Lunev" , qemu-devel@nongnu.org Cc: den@openvz.org, Paolo Bonzini , Richard Henderson , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Zhao Liu Subject: Re: [PATCH 08/10] system/cpus: hold off the BQL watchdog under a debugger In-Reply-To: <20260915203455.580999-9-den@openvz.org> References: <20260915203455.580999-1-den@openvz.org> <20260915203455.580999-9-den@openvz.org> Date: Tue, 17 Nov 2026 15:25:13 -0300 Message-ID: <878q2rs4c6.fsf@suse.de> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 13E6622018 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-13.51 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,qualcomm.com:email,linaro.org:email,intel.com:email,suse.de:dkim,suse.de:email,openvz.org:email]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Score: -13.51 Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 "Denis V. Lunev" writes: > From: Denis V. Lunev > > A debugger stops every thread, so the sequence counter freezes at an > odd value and the watchdog cannot tell that apart from an owner that > never lets go. Attaching gdb to a running guest would report a hang > that is not one. > > Skip the report while a tracer is attached, and restart the count so > that a detach gets a full deadline before the watchdog can fire. Any > ptracer sets TracerPid, so strace holds the watchdog off as well. > > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Philippe Mathieu-Daud=C3=A9 > Cc: Zhao Liu > Signed-off-by: Denis V. Lunev > --- > system/cpus.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/system/cpus.c b/system/cpus.c > index 9e03f303f2..03a07e4824 100644 > --- a/system/cpus.c > +++ b/system/cpus.c > @@ -441,6 +441,10 @@ static void *bql_watchdog_fn(void *opaque) > if (++stuck_polls < BQL_WATCHDOG_POLLS) { > continue; > } > + if (qemu_debugger_attached()) { > + stuck_polls =3D 0; > + continue; > + } > if (seq =3D=3D reported) { > continue; > } Reviewed-by: Fabiano Rosas