From: Thomas Gleixner <tglx@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
"John Stultz" <jstultz@google.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miroslav Lichvar" <mlichvar@redhat.com>
Cc: linux-kernel@vger.kernel.org, "Thomas Weißschuh" <linux@weissschuh.net>
Subject: Re: [PATCH 3/3] alarmtimer: Return early if try_module_get() fails
Date: Mon, 09 Nov 2026 20:49:19 +0100 [thread overview]
Message-ID: <878q31vl8g.ffs@fw13> (raw)
In-Reply-To: <20261102-alarmtimer-locking-v1-3-3c79a698aeae@weissschuh.net>
On Mon, Nov 02 2026 at 06:11, Thomas Weißschuh wrote:
> @@ -94,17 +93,16 @@ static int alarmtimer_rtc_add_device(struct device *dev)
>
> device_init_wakeup(&pdev->dev, true);
The wakeup functionality is enabled _before_ the last condition
try_module_get() is evaluated. That doesn't make any sense.
next prev parent reply other threads:[~2026-11-09 19:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 6:11 [PATCH 0/3] alarmtimer: Drop the spinlock around the rtcdev variable Thomas Weißschuh
2026-11-02 6:11 ` [PATCH 1/3] " Thomas Weißschuh
2026-11-09 19:53 ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2026-11-02 6:11 ` [PATCH 2/3] alarmtimer: Return early if platform_device_register_data() fails Thomas Weißschuh
2026-11-09 19:53 ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2026-11-02 6:11 ` [PATCH 3/3] alarmtimer: Return early if try_module_get() fails Thomas Weißschuh
2026-11-09 19:49 ` Thomas Gleixner [this message]
2026-11-09 19:53 ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878q31vl8g.ffs@fw13 \
--to=tglx@kernel.org \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mlichvar@redhat.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.