Re: [PATCH] qapi: convert intro sections fixup

[Markus Armbruster <armbru@redhat.com>]

John Snow <jsnow@redhat.com> writes:

> On Wed, Sep 30, 2026 at 1:39 AM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> John Snow <jsnow@redhat.com> writes:
>>
>> > "We" (Me, I, Myself) missed two last spots during bulk conversion of the
>> > intro section syntax.
>> >
>> > Some definitions are still intentionally left without an intro
>> > section: BlockdevSnapshotSync is the only case I am presently aware
>> > of.
>>
>> There are quite a few more, but BlockdevSnapshotSync is the only one
>> followed by a plain section.
>>
>> > The remaining two were genuinely just missed; convert them now.
>> >
>> > Reported-by: Markus Armbruster <armbru@redhat.com>
>> > Signed-off-by: John Snow <jsnow@redhat.com>
>> > ---
>> >  qapi/machine-s390x.json |  4 ++--
>> >  qapi/qom.json           | 14 +++++++-------
>> >  2 files changed, 9 insertions(+), 9 deletions(-)
>> >
>> > diff --git a/qapi/machine-s390x.json b/qapi/machine-s390x.json
>> > index 8d8cbe2fb75..9ae559bbc2d 100644
>> > --- a/qapi/machine-s390x.json
>> > +++ b/qapi/machine-s390x.json
>> > @@ -150,8 +150,8 @@
>> >
>> >  ##
>> >  # @DummyBootCertificates:
>> > -#
>> > -# Not used by QMP; hack to let us use BootCertificatesList internally.
>> > +#     Not used by QMP; hack to let us use BootCertificatesList
>> > +#     internally.
>> >  #
>> >  # Since: 11.2
>> >  ##
>> > diff --git a/qapi/qom.json b/qapi/qom.json
>> > index e03ede34421..2d0d0e47fbb 100644
>> > --- a/qapi/qom.json
>> > +++ b/qapi/qom.json
>> > @@ -1039,13 +1039,13 @@
>> >
>> >  ##
>> >  # @SevSnpGuestProperties:
>> > -#
>> > -# Properties for sev-snp-guest objects.  Most of these are direct
>> > -# arguments for the KVM_SNP_* interfaces documented in the Linux
>> > -# kernel source under
>> > -# Documentation/arch/x86/amd-memory-encryption.rst, which are in turn
>> > -# closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware commands
>> > -# documented in the SEV-SNP Firmware ABI Specification (Rev 0.9).
>> > +#     Properties for sev-snp-guest objects.  Most of these are direct
>> > +#     arguments for the KVM_SNP_* interfaces documented in the Linux
>> > +#     kernel source under
>> > +#     Documentation/arch/x86/amd-memory-encryption.rst, which are in
>> > +#     turn closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware
>> > +#     commands documented in the SEV-SNP Firmware ABI Specification
>> > +#     (Rev 0.9).
>> >  #
>> >  # More usage information is also available in the QEMU source tree
>> >  # under docs/amd-memory-encryption.
>>
>> Hmm, shouldn't we split this one?
>
> Looping back to stuff that got missed:
>
> Split how? I think I have to rephrase this a bit, because when it gets
> inlined, it (might) be lacking the context of what specifically it
> refers to, i.e. "Most of these" might become ambiguous.

Yes.

Could s/these/the properties/ suffice for now?

  ##
  # @SevSnpGuestProperties:
  #     Properties for sev-snp-guest objects.
  #
  #     Most of the properties are direct arguments for the KVM_SNP_*
  #     interfaces documented in the Linux kernel source under
  #     Documentation/arch/x86/amd-memory-encryption.rst, which are in
  #     turn closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware
  #     commands documented in the SEV-SNP Firmware ABI Specification
  #     (Rev 0.9).