From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9788BC61DB6 for ; Tue, 25 Aug 2026 09:10:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wynAz-0004cb-5a; Tue, 25 Aug 2026 05:10:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wynAx-0004cF-Vk for qemu-devel@nongnu.org; Tue, 25 Aug 2026 05:10:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wynAw-00055p-5F for qemu-devel@nongnu.org; Tue, 25 Aug 2026 05:10:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787649032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JArLY+EmhIgvh5Ef/Uzcm9WESCObz7TaJXVm360uebE=; b=Msj91aoYXl6Uo8VhTavkGPJ4bBu85NqESwqy3uBxOmfxT2ok8pdRdOVIFHcFQ63puUmocH ON7dkXaUXgMDcbhmCV76Ml/oOvAwbphysE0MIDT0F/Y5gT+ZNjfRjHTudkFFxiB6vbexmR YwK08G1zOjOtbNGC0YRfTElMAxAilCc= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-456-yYAX_uXhOae7aK38TZpzxw-1; Tue, 25 Aug 2026 05:10:29 -0400 X-MC-Unique: yYAX_uXhOae7aK38TZpzxw-1 X-Mimecast-MFC-AGG-ID: yYAX_uXhOae7aK38TZpzxw_1787649028 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 260E5186A6EE; Tue, 25 Aug 2026 09:10:28 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.12]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B5DDA1800348; Tue, 25 Aug 2026 09:10:27 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 2B76121E6920; Tue, 25 Aug 2026 11:10:25 +0200 (CEST) From: Markus Armbruster To: "Denis V. Lunev" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Stefan Hajnoczi , Eric Blake Subject: Re: [PATCH v6 19/25] parallels: report the stored dirty bitmaps in qemu-img info In-Reply-To: <20260817185942.1065143-20-den@openvz.org> (Denis V. Lunev's message of "Mon, 17 Aug 2026 20:59:36 +0200") References: <20260817185942.1065143-1-den@openvz.org> <20260817185942.1065143-20-den@openvz.org> Date: Tue, 25 Aug 2026 11:10:25 +0200 Message-ID: <878q5uo9a6.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org "Denis V. Lunev" writes: > From: Denis V. Lunev > > Nothing tells which persistent bitmaps an image carries. qemu-img info > says nothing about them, and the only other way to see one is to export > the image over NBD and ask for a bitmap by name, which needs the name > beforehand. > > Add ImageInfoSpecificParallels with the bitmaps and their granularity, > as qcow2 reports the contents of its bitmap directory: > > Format specific information: > bitmaps: > [0]: > name: b2c9e1a4-5d3f-4e8b-9a7c-6f0d1e2b3a45 > granularity: 65536 > > The list is built from the bitmaps loaded at open time rather than from > a second pass over the Format Extension, as every bitmap the extension > carries is loaded and marked persistent there. On a node which is open > that also covers a bitmap which was created but not stored yet, which is > what the field says: qemu-img info opens the image on its own, so there > the two are the same thing. The last sentence confuses me. > An image with no bitmaps leaves the structure empty, and > bdrv_image_info_specific_dump() prints nothing for an empty one, so the > output for such an image does not change. Output of what? I guess it's "info block" and "qemu-img info", because these call bdrv_image_info_specific_dump(). > Cc: Stefan Hajnoczi > Cc: Eric Blake > Cc: Markus Armbruster > Signed-off-by: Denis V. Lunev [...] > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 1f87b07850..4bc8b45efe 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -200,7 +200,7 @@ > # Since: 1.7 > ## > { 'enum': 'ImageInfoSpecificKind', > - 'data': [ 'qcow2', 'vmdk', 'luks', 'rbd', 'file' ] } > + 'data': [ 'qcow2', 'vmdk', 'luks', 'rbd', 'file', 'parallels' ] } > > ## > # @ImageInfoSpecificQCow2Wrapper: > @@ -255,6 +255,41 @@ > { 'struct': 'ImageInfoSpecificFileWrapper', > 'data': { 'data': 'ImageInfoSpecificFile' } } > > +## > +# @ParallelsBitmapInfo: > +# > +# Parallels dirty bitmap information. > +# > +# @name: the name of the bitmap > +# > +# @granularity: granularity of the bitmap in bytes > +# > +# Since: 11.2 > +## > +{ 'struct': 'ParallelsBitmapInfo', > + 'data': { 'name': 'str', 'granularity': 'uint32' } } > + > +## > +# @ImageInfoSpecificParallels: > +# > +# @bitmaps: A list of the persistent dirty bitmaps of the image, > +# including the ones which are not written out yet Pardon my ignorance... Is "not written out yet" relevant to a user / management application? ImageInfoSpecificQCow2 also has a @bitmaps member. Its documentation is # @bitmaps: A list of qcow2 bitmap details (since 4.0) Are these "persistent dirty bitmaps" as well, or something else? > +# > +# Since: 11.2 > +## > +{ 'struct': 'ImageInfoSpecificParallels', > + 'data': { '*bitmaps': ['ParallelsBitmapInfo'] } } Please put these right after ImageInfoSpecificFile to preserve the existing order of things: All the ImageInfoSpecificFOO in order of ImageInfoSpecificKind members ImageInfoSpecificKind All the ImageInfoSpecificFOOWrapper in order of ImageInfoSpecificKind members ImageInfoSpecific > + > +## > +# @ImageInfoSpecificParallelsWrapper: > +# > +# @data: image information specific to Parallels > +# > +# Since: 11.2 > +## > +{ 'struct': 'ImageInfoSpecificParallelsWrapper', > + 'data': { 'data': 'ImageInfoSpecificParallels' } } > + > ## > # @ImageInfoSpecific: > # > @@ -273,7 +308,8 @@ > 'vmdk': 'ImageInfoSpecificVmdkWrapper', > 'luks': 'ImageInfoSpecificLUKSWrapper', > 'rbd': 'ImageInfoSpecificRbdWrapper', > - 'file': 'ImageInfoSpecificFileWrapper' > + 'file': 'ImageInfoSpecificFileWrapper', > + 'parallels': 'ImageInfoSpecificParallelsWrapper' > } } > > ## [...]