From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32890C55162 for ; Thu, 30 Jul 2026 14:13:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x/hYq6WukPT+CBs04bgqFwLb+HrTy9F7WUlTzIOLVK0=; b=DOHSHLiiLTOkcv dRVCt/Ws9RrU1kng4WhIhPRjYuRTQeD+w0WXpIwjCGr0u0qKOLzYwVZpd5x4sESTUf7GVAp7Xsgwt EtAK3Ke7gjm7Duw8ZY96boNIaNdX6Z2gLGxRkZmkVPR02wRzB/OGspyRvfexCQUiFUcKZuNexd6// tOA8C1DlXrKdj4On6drv+GbhVsvGgvSXRS+4d1ICT8jLALegFrNCocwp2Ue4pk4XpkiZX8qDDQJc0 3jC3H7Gr1fQ3E9IlzaZNAWpI3qJD6gT/t0EZeZ9zUPK3agrgLA9fA33a9ehutgXSx21dkUJ8eY6DJ kV4gFUcUNSqpF+cXOMVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpRWH-0000000AiaY-3ed7; Thu, 30 Jul 2026 14:13:57 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpRWG-0000000AiZT-3U2k for linux-phy@lists.infradead.org; Thu, 30 Jul 2026 14:13:56 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 97369413C2; Thu, 30 Jul 2026 14:13:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 040B21F00A3D; Thu, 30 Jul 2026 14:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785420836; bh=3RxfctGmL/FgTZ/YU2LMud4uponhhpLGkT6ewhWPZZU=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=S2qQxBvKAUWnJn9NGEGHe/vywX73b7yE/wW/7axe0RZcaE0xeC9UY5Gwm7tHvq/ra ZPR55sCsgjHkIDf+NtEaH+Pv32GRiDcKBfnQUPFmEo8O/ob4XKnjsEdTYY7EsXnJO/ QPXq3CtkUgo6oN+r6grkQRSObJDNfAOv2OQgbUvmZyhgUV7QcLbWWQF11SdnvwUZ+7 q/tL8csYGh53euZb4ckiijH3QNAfZuoi66GnqLKUVDUtwGqLh0uGCOpOGZud/EypMM 5rTF6H1eAeC7vt6NnCTzlZzyywc/4LhmCDTJ4KRfSEmP6Q//x5Fd83oZ7d4TSFb98K LLZ9OMqhchY6Q== From: Mattijs Korpershoek To: sashiko-reviews@lists.linux.dev, Mattijs Korpershoek Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, linux-phy@lists.infradead.org, vkoul@kernel.org Subject: Re: [PATCH 1/2] dt-bindings: phy: Add sa8255p high-speed USB PHY In-Reply-To: <20260730140606.08BEC1F000E9@smtp.kernel.org> References: <20260730-phy-qcom-snps-femto-v2-8255-v1-0-8b8bf5105a68@kernel.org> <20260730-phy-qcom-snps-femto-v2-8255-v1-1-8b8bf5105a68@kernel.org> <20260730140606.08BEC1F000E9@smtp.kernel.org> Date: Thu, 30 Jul 2026 16:13:54 +0200 Message-ID: <878q6sy38d.fsf@kernel.org> MIME-Version: 1.0 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKdWwgMzAsIDIwMjYgYXQgMTQ6MDYsIHNhc2hpa28tYm90QGtlcm5lbC5vcmcgd3Jv dGU6Cgo+IFRoYW5rIHlvdSBmb3IgeW91ciBjb250cmlidXRpb24hIFNhc2hpa28gQUkgcmV2aWV3 IGZvdW5kIDEgcG90ZW50aWFsIGlzc3VlKHMpIHRvIGNvbnNpZGVyOgo+IC0gW01lZGl1bV0gTWlz c2luZyBoYXJkd2FyZS1zcGVjaWZpYyBQSFkgdHVuaW5nIHBhcmFtZXRlcnMgZm9yIHRoZSBTeW5v cHN5cyBGZW10byBIaWdoLVNwZWVkIFVTQiBQSFkgVjIuCj4gLS0KPgo+IC0tLSBQYXRjaCBbMV06 IFtQQVRDSCAxLzJdIGR0LWJpbmRpbmdzOiBwaHk6IEFkZCBzYTgyNTVwIGhpZ2gtc3BlZWQgVVNC IFBIWSAtLS0KPiBjb21taXQgMDRiYzkxYTZmZTA2MjYxZTA5OWFlOGZkYTFiYjkwZTM0ZDBmMjhm Ywo+IEF1dGhvcjogTWF0dGlqcyBLb3JwZXJzaG9layA8bWtvcnBlcnNob2VrQGtlcm5lbC5vcmc+ Cj4KPiBkdC1iaW5kaW5nczogcGh5OiBBZGQgc2E4MjU1cCBoaWdoLXNwZWVkIFVTQiBQSFkKPgo+ IFRoaXMgY29tbWl0IGludHJvZHVjZXMgYSBuZXcgZGV2aWNlIHRyZWUgYmluZGluZyBmb3IgdGhl IFF1YWxjb21tIFNBODI1NXAgCj4gU3lub3BzeXMgRmVtdG8gSGlnaC1TcGVlZCBVU0IgUEhZIFYy LiBJdCBzcGVjaWZpZXMgdGhhdCB0aGUgaGFyZHdhcmUgdXNlcyAKPiBTQ01JIHBvd2VyIGRvbWFp bnMgdG8gbWFuYWdlIHJlc291cmNlcyBsaWtlIGNsb2NrcywgaW50ZXJjb25uZWN0cywgYW5kIAo+ IHJlc2V0cywgcmF0aGVyIHRoYW4gZGVmaW5pbmcgdGhlbSBpbmRpdmlkdWFsbHkuCj4KPj4gZGlm ZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waHkvcWNvbSxzYTgy NTVwLXVzYi1ocy1waHkueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9w aHkvcWNvbSxzYTgyNTVwLXVzYi1ocy1waHkueWFtbAo+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ PiBpbmRleCAwMDAwMDAwMDAwMDAwLi4wOWY3Y2E2ZTdmNzI3Cj4+IC0tLSAvZGV2L251bGwKPj4g KysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BoeS9xY29tLHNhODI1NXAt dXNiLWhzLXBoeS55YW1sCj4KPiBbIC4uLiBdCj4KPj4gK3JlcXVpcmVkOgo+PiArICAtIGNvbXBh dGlibGUKPj4gKyAgLSByZWcKPj4gKyAgLSAiI3BoeS1jZWxscyIKPj4gKyAgLSBwb3dlci1kb21h aW5zCj4+ICsgIC0gcG93ZXItZG9tYWluLW5hbWVzCj4+ICsKPj4gK2FkZGl0aW9uYWxQcm9wZXJ0 aWVzOiBmYWxzZQo+Cj4gW1NldmVyaXR5OiBNZWRpdW1dCj4gU2luY2UgdGhpcyBJUCBibG9jayBp cyBzdGlsbCB0aGUgU3lub3BzeXMgRmVtdG8gSGlnaC1TcGVlZCBVU0IgUEhZIFYyLCAKPiB3b3Vs ZCBib2FyZCBjb25maWd1cmF0aW9ucyBmb3IgdGhpcyBwbGF0Zm9ybSBzdGlsbCBuZWVkIHRvIGFw cGx5IHN0YW5kYXJkIAo+IGhhcmR3YXJlIHR1bmluZyBwYXJhbWV0ZXJzIChzdWNoIGFzIHFjb20s c3F1ZWxjaC1kZXRlY3Rvci1icCk/Cj4KPiBXaGlsZSBjbG9ja3MgYW5kIHJlc2V0cyBhcmUgYWJz dHJhY3RlZCBpbnRvIFNDTUkgcG93ZXIgZG9tYWlucyBoZXJlLCB0aGUgCj4gbWVtb3J5LW1hcHBl ZCByZWcgc3BhY2UgaXMgc3RpbGwgcHJvdmlkZWQgYW5kIHR5cGljYWxseSB1c2VkIHRvIHByb2dy YW0gCj4gdGhlc2Ugc2lnbmFsIGNoYXJhY3RlcmlzdGljcy4gV2l0aCBhZGRpdGlvbmFsUHJvcGVy dGllcyBzZXQgdG8gZmFsc2UsIAo+IHNjaGVtYSB2YWxpZGF0aW9uIHdpbGwgZmFpbCBmb3IgYW55 IGJvYXJkIGRldmljZSB0cmVlIHRoYXQgYXR0ZW1wdHMgdG8gCj4gb3ZlcnJpZGUgdGhlc2UgdmFs aWQgUEhZIHR1bmluZyBwcm9wZXJ0aWVzLgo+Cj4gTWlnaHQgaXQgYmUgbmVjZXNzYXJ5IHRvIGlu Y2x1ZGUgdGhlc2UgdHVuaW5nIHByb3BlcnRpZXMsIHBlcmhhcHMgYnkgCj4gcmVmZXJlbmNpbmcg YSBjb21tb24gc2NoZW1hLCBzbyB0aGF0IGJvYXJkcyBjYW4gc2FmZWx5IHR1bmUgc3F1ZWxjaCAK PiBkZXRlY3Rpb24gYW5kIHByZS1lbXBoYXNpcyB3aXRob3V0IHRyaWdnZXJpbmcgdmFsaWRhdGlv biBlcnJvcnM/CgpObywgZnJvbSB0aGUgdGVzdGluZyBJJ3ZlIGRvbmUgaXQncyBub3QgbmVlZGVk IHRvIGFkZCBhbnkgUEhZIHR1bmluZyBwcm9wZXJ0aWVzLgoKPgo+PiArCj4+ICtleGFtcGxlczoK Pj4gKyAgLSB8Cj4+ICsgICAgc29jIHsKPgo+IFsgLi4uIF0KPgo+IC0tIAo+IFNhc2hpa28gQUkg cmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDczMC1waHktcWNv bS1zbnBzLWZlbXRvLXYyLTgyNTUtdjEtMC04YjhiZjUxMDVhNjhAa2VybmVsLm9yZz9wYXJ0PTEK Ci0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF100347BD7; Thu, 30 Jul 2026 14:13:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785420837; cv=none; b=gzI6Vd1c6Br0kz98Su+rDBogjncta4B/+hi8w5i4//W3rNNcdi9/tX7k6cGkDQPkym50fRQRFEE1epN6oJLi0GfYnNB/BP5RwmvMgsFy+s7Wt3Z5VdTsVmZmWtvuNDOjMbfE6veJeR6jxfZ8w3I7SlUT5dBbjuv6wpJbq6yVVDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785420837; c=relaxed/simple; bh=axofcvun7XcWE8IeXc0S1Tui38f+OoEDJgB7ZB8duNA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=q0r1TVKd2dbsNFH1zfJKTBtFCaGOeT+SzSIIIO1XHsnqxVrNoOlonn0RJGIFPiCoXO0EOGiF0dYeR7Y1qSKHWCUq1asucL+SEVLxVuLwCKNb23h/UgfnUzpKgLRW0f2P8Q0yLjTdCfbc49odH/3tLElGJ6GxaBhtvQ68Zi8xHB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S2qQxBvK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S2qQxBvK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 040B21F00A3D; Thu, 30 Jul 2026 14:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785420836; bh=3RxfctGmL/FgTZ/YU2LMud4uponhhpLGkT6ewhWPZZU=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=S2qQxBvKAUWnJn9NGEGHe/vywX73b7yE/wW/7axe0RZcaE0xeC9UY5Gwm7tHvq/ra ZPR55sCsgjHkIDf+NtEaH+Pv32GRiDcKBfnQUPFmEo8O/ob4XKnjsEdTYY7EsXnJO/ QPXq3CtkUgo6oN+r6grkQRSObJDNfAOv2OQgbUvmZyhgUV7QcLbWWQF11SdnvwUZ+7 q/tL8csYGh53euZb4ckiijH3QNAfZuoi66GnqLKUVDUtwGqLh0uGCOpOGZud/EypMM 5rTF6H1eAeC7vt6NnCTzlZzyywc/4LhmCDTJ4KRfSEmP6Q//x5Fd83oZ7d4TSFb98K LLZ9OMqhchY6Q== From: Mattijs Korpershoek To: sashiko-reviews@lists.linux.dev, Mattijs Korpershoek Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, linux-phy@lists.infradead.org, vkoul@kernel.org Subject: Re: [PATCH 1/2] dt-bindings: phy: Add sa8255p high-speed USB PHY In-Reply-To: <20260730140606.08BEC1F000E9@smtp.kernel.org> References: <20260730-phy-qcom-snps-femto-v2-8255-v1-0-8b8bf5105a68@kernel.org> <20260730-phy-qcom-snps-femto-v2-8255-v1-1-8b8bf5105a68@kernel.org> <20260730140606.08BEC1F000E9@smtp.kernel.org> Date: Thu, 30 Jul 2026 16:13:54 +0200 Message-ID: <878q6sy38d.fsf@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, Jul 30, 2026 at 14:06, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issu= e(s) to consider: > - [Medium] Missing hardware-specific PHY tuning parameters for the Synops= ys Femto High-Speed USB PHY V2. > -- > > --- Patch [1]: [PATCH 1/2] dt-bindings: phy: Add sa8255p high-speed USB P= HY --- > commit 04bc91a6fe06261e099ae8fda1bb90e34d0f28fc > Author: Mattijs Korpershoek > > dt-bindings: phy: Add sa8255p high-speed USB PHY > > This commit introduces a new device tree binding for the Qualcomm SA8255p= =20 > Synopsys Femto High-Speed USB PHY V2. It specifies that the hardware uses= =20 > SCMI power domains to manage resources like clocks, interconnects, and=20 > resets, rather than defining them individually. > >> diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8255p-usb-hs-p= hy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8255p-usb-hs-phy.yaml >> new file mode 100644 >> index 0000000000000..09f7ca6e7f727 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/qcom,sa8255p-usb-hs-phy.yaml > > [ ... ] > >> +required: >> + - compatible >> + - reg >> + - "#phy-cells" >> + - power-domains >> + - power-domain-names >> + >> +additionalProperties: false > > [Severity: Medium] > Since this IP block is still the Synopsys Femto High-Speed USB PHY V2,=20 > would board configurations for this platform still need to apply standard= =20 > hardware tuning parameters (such as qcom,squelch-detector-bp)? > > While clocks and resets are abstracted into SCMI power domains here, the= =20 > memory-mapped reg space is still provided and typically used to program=20 > these signal characteristics. With additionalProperties set to false,=20 > schema validation will fail for any board device tree that attempts to=20 > override these valid PHY tuning properties. > > Might it be necessary to include these tuning properties, perhaps by=20 > referencing a common schema, so that boards can safely tune squelch=20 > detection and pre-emphasis without triggering validation errors? No, from the testing I've done it's not needed to add any PHY tuning proper= ties. > >> + >> +examples: >> + - | >> + soc { > > [ ... ] > > --=20 > Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260730-phy-qcom= -snps-femto-v2-8255-v1-0-8b8bf5105a68@kernel.org?part=3D1