All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Naveen N Rao (AMD)" <naveen@kernel.org>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	Nikunj A Dadhania <nikunj@amd.com>,
	Manali Shukla <manali.shukla@amd.com>,
	Bharata B Rao <bharata@amd.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v3 2/3] x86/apic: Introduce a variable to track the number of EILVT registers
Date: Tue, 21 Jul 2026 14:42:35 +0200	[thread overview]
Message-ID: <878q74ldj8.ffs@fw13> (raw)
In-Reply-To: <39d39c3b91d174f4090fb954c6690edae9ed8295.1784619898.git.naveen@kernel.org>

On Tue, Jul 21 2026 at 13:33, Naveen N. Rao wrote:
>  
> +extern unsigned int apic_eilvt_count;

Please do not create yet another global variable. It's an APIC property,
so struct apic is the obvious place for it, no?

Thanks,

        tglx

  reply	other threads:[~2026-07-21 12:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21  8:03 [PATCH v3 0/3] Support additional AMD EILVT registers Naveen N Rao (AMD)
2026-07-21  8:03 ` [PATCH v3 1/3] perf/amd/ibs: Limit the max EILVT register count for AMD family 0x10 Naveen N Rao (AMD)
2026-07-21  8:03 ` [PATCH v3 2/3] x86/apic: Introduce a variable to track the number of EILVT registers Naveen N Rao (AMD)
2026-07-21 12:42   ` Thomas Gleixner [this message]
2026-07-22 14:04     ` Naveen N Rao
2026-07-21  8:03 ` [PATCH v3 3/3] x86/apic: Drop APIC_EILVT_NR_MAX and switch to using apic_eilvt_count Naveen N Rao (AMD)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878q74ldj8.ffs@fw13 \
    --to=tglx@linutronix.de \
    --cc=bharata@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manali.shukla@amd.com \
    --cc=naveen@kernel.org \
    --cc=nikunj@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.