All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Henriques <luis@igalia.com>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: fuse-devel@lists.linux.dev,  linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fuse: add fusex filesystem
Date: Tue, 26 May 2026 17:15:52 +0100	[thread overview]
Message-ID: <878q96kuyv.fsf@igalia.com> (raw)
In-Reply-To: <20260429102058.1362965-1-mszeredi@redhat.com> (Miklos Szeredi's message of "Wed, 29 Apr 2026 12:20:57 +0200")

Hi Miklos!

I'm not sure if you have a more up-to-date version of your patch (or
patchset, as you mentioned you'd be splitting it).  But here's a small
issue I have fixed locally a while back, when I started playing with
fusex:

On Wed, Apr 29 2026, Miklos Szeredi wrote:

<snip>

> +static struct inode *fusex_get_inode(struct super_block *sb, struct fusex_id *id)
> +{
> +	struct inode *inode = fusex_iget(sb, id);
> +	struct fuse_statx_out statx;
> +	int err;
> +
> +	if (!inode)
> +		return ERR_PTR(-ENOMEM);
> +
> +	if (inode_state_read_once(inode) & I_NEW) {
> +		inode_state_set(inode, I_DONTCACHE);

inode_state_set() assumes the caller holds inode->i_lock, so we will see a
kernel splat from a lockdep assertion.

Cheers,
-- 
Luís

> +		err = fusex_send_statx(inode, &statx);
> +		if (err) {
> +			discard_new_inode(inode);
> +			return ERR_PTR(err);
> +		}
> +		fusex_set_attr(inode, &statx.stat);
> +		fusex_init_inode(inode);
> +		unlock_new_inode(inode);
> +	}
> +	return inode;
> +}

      parent reply	other threads:[~2026-05-26 16:16 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 10:20 [PATCH] fuse: add fusex filesystem Miklos Szeredi
2026-05-07  8:31 ` Horst Birthelmer
2026-05-08 13:01   ` Amir Goldstein
2026-05-12  8:17     ` Miklos Szeredi
2026-05-12 13:08       ` Amir Goldstein
2026-05-12 13:46         ` Bernd Schubert
2026-05-12 21:07           ` Amir Goldstein
2026-05-12 21:26             ` Bernd Schubert
2026-05-12  8:11   ` Miklos Szeredi
2026-05-12 10:29     ` Horst Birthelmer
2026-05-08 17:29 ` Horst Birthelmer
2026-05-12  8:20   ` Miklos Szeredi
2026-05-11  8:50 ` Horst Birthelmer
2026-05-12  8:34   ` Miklos Szeredi
2026-05-12  5:05 ` Joanne Koong
2026-05-12  9:18   ` Miklos Szeredi
2026-05-12 13:22     ` Amir Goldstein
2026-05-12 19:22       ` Joanne Koong
2026-05-12 21:28         ` Amir Goldstein
2026-05-14 23:24           ` Joanne Koong
2026-05-15 20:17             ` Amir Goldstein
2026-05-15 22:32               ` Joanne Koong
2026-05-15 23:18                 ` Amir Goldstein
2026-05-12 17:33     ` Joanne Koong
2026-05-12 20:37       ` Darrick J. Wong
2026-05-21 17:21 ` Bernd Schubert
2026-05-26 16:15 ` Luis Henriques [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878q96kuyv.fsf@igalia.com \
    --to=luis@igalia.com \
    --cc=fuse-devel@lists.linux.dev \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mszeredi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.