From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7027FDEE29 for ; Thu, 23 Apr 2026 17:31:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFxsg-0007Jv-N0; Thu, 23 Apr 2026 13:30:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFxsS-0007GP-GK for qemu-devel@nongnu.org; Thu, 23 Apr 2026 13:30:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFxsQ-0001Yn-PY for qemu-devel@nongnu.org; Thu, 23 Apr 2026 13:30:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776965407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P0IDz+unECUag28QHv433Cz0pxf5uryWb30H9XoKREo=; b=jBgAGyMUL5nNwmYKqpA1obX2USz8KMDbwtU+4F5EciXMfGvN8u00Xxw2/x0miQG/8nxVj6 7otq1PGUBRgNkubM3vpZccNm+Hhd70FO/E+4udvgbFxbZvVaW1xjqJjsYhX5tNhHvfDBbZ EtUVzgnJEpZ5ChpBgiGDUlRes/cF8dE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-rKAtRIouMaawoL20gTh-5A-1; Thu, 23 Apr 2026 13:30:05 -0400 X-MC-Unique: rKAtRIouMaawoL20gTh-5A-1 X-Mimecast-MFC-AGG-ID: rKAtRIouMaawoL20gTh-5A_1776965404 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8A9091956056 for ; Thu, 23 Apr 2026 17:30:04 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.30]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 49FD7180058B for ; Thu, 23 Apr 2026 17:30:04 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B800621E6A28; Thu, 23 Apr 2026 19:30:01 +0200 (CEST) From: Markus Armbruster To: Paolo Bonzini Cc: qemu-devel@nongnu.org Subject: Re: [PATCH] tests: add test for json-streamer.c error recovery In-Reply-To: (Paolo Bonzini's message of "Thu, 23 Apr 2026 18:24:19 +0200") References: <20260331095950.512326-1-pbonzini@redhat.com> <87cxzqrwqt.fsf@pond.sub.org> Date: Thu, 23 Apr 2026 19:30:01 +0200 Message-ID: <878qadmvom.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Paolo Bonzini writes: > On Thu, Apr 23, 2026 at 8:56=E2=80=AFAM Markus Armbruster wrote: >> > + } else { >> > + qobject_unref(r->result); >> >> Unexpected calls to parse_emit() won't be detected as long as the last >> one yields the expected expression. Worth detecting? I'm not quite >> sure. As far as I can tell, this is not reached at the moment. > > It's only covered in /errors/multiple_values of tests/unit/check-qson.c, = yes. > >> The stupidest way to detect is to assert r->result is still null. > > I'm all for simplicity. > >> Can't do that if we want to cover parsing multiple JSON expressions in >> sequence. Collect all the results in an array? > > Yes, but not now. For now the assert will do. Makes sense. Thanks!