From: Thomas Gleixner <tglx@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>, Calvin Owens <calvin@wbinvd.org>,
Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, arighi@nvidia.com,
yaozhenguo1@gmail.com, tj@kernel.org,
feng.tang@linux.alibaba.com, lirongqing@baidu.com,
realwujing@gmail.com, hu.shengming@zte.com.cn,
dianders@chromium.org, joel.granados@kernel.org,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
x86@kernel.org
Subject: Re: [PATCH] clockevents: Prevent timer interrupt starvation
Date: Fri, 03 Apr 2026 16:43:34 +0200 [thread overview]
Message-ID: <878qb46r55.ffs@tglx> (raw)
In-Reply-To: <20260403121648.GZ3738010@noisy.programming.kicks-ass.net>
On Fri, Apr 03 2026 at 14:16, Peter Zijlstra wrote:
>> delta = ktime_to_ns(ktime_sub(expires, ktime_get()));
>> +
>> + /* Don't reprogram when a forced event is pending */
>> + if (dev->next_event_forced && delta <= (int64_t)dev->min_delta_ns)
>> + return 0;
>> +
>> if (delta <= 0)
>> return force ? clockevents_program_min_delta(dev) : -ETIME;
>>
>
> This last hunk seems duplicate of the clockevents_program_min_delta()
> change, that also will bail when next_event_forced is set.
Yeah. I was planning to look into it with brain awake today again.
> Also, I note, thing (except shutdown) will ever clear next_event_forced;
> and I'm thinking that any interrupt or normal reprogram should be doing
> that.
See my reply to Calvin. :)
next prev parent reply other threads:[~2026-04-03 14:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 23:32 [BUG] Random hard lockup with userspace %ip on 7.0-rc5 Calvin Owens
2026-03-25 9:03 ` Petr Mladek
2026-03-25 16:56 ` Thomas Gleixner
2026-04-01 1:58 ` Calvin Owens
2026-04-01 15:01 ` Thomas Gleixner
2026-04-01 15:12 ` Borislav Petkov
2026-04-01 16:34 ` Borislav Petkov
2026-04-02 17:07 ` [PATCH] clockevents: Prevent timer interrupt starvation Thomas Gleixner
2026-04-03 5:11 ` Calvin Owens
2026-04-03 14:41 ` Thomas Gleixner
2026-04-03 15:58 ` Calvin Owens
2026-04-03 19:00 ` Thomas Gleixner
2026-04-04 0:15 ` Calvin Owens
2026-04-08 8:52 ` Thomas Gleixner
2026-04-03 12:16 ` Peter Zijlstra
2026-04-03 14:43 ` Thomas Gleixner [this message]
2026-04-03 16:17 ` Thomas Gleixner
2026-04-03 21:01 ` Peter Zijlstra
2026-04-03 21:24 ` Thomas Gleixner
2026-04-03 22:14 ` Thomas Gleixner
2026-04-03 22:21 ` Peter Zijlstra
2026-03-27 1:36 ` [BUG] Random hard lockup with userspace %ip on 7.0-rc5 Feng Tang
2026-03-27 15:36 ` Calvin Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qb46r55.ffs@tglx \
--to=tglx@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=arighi@nvidia.com \
--cc=bp@alien8.de \
--cc=bsegall@google.com \
--cc=calvin@wbinvd.org \
--cc=dianders@chromium.org \
--cc=dietmar.eggemann@arm.com \
--cc=feng.tang@linux.alibaba.com \
--cc=frederic@kernel.org \
--cc=hu.shengming@zte.com.cn \
--cc=joel.granados@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=realwujing@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=x86@kernel.org \
--cc=yaozhenguo1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.