From: Andreas Hindborg <a.hindborg@kernel.org>
To: Daniel Almeida <daniel.almeida@collabora.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Gary Guo" <gary@garyguo.net>,
"Filipe Xavier" <felipeaggger@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, felipe_life@live.com,
linux-kernel@vger.kernel.org, "Lyude Paul" <lyude@redhat.com>
Subject: Re: [PATCH v8] rust: add new macro for common bitflag operations
Date: Fri, 16 Jan 2026 09:38:44 +0100 [thread overview]
Message-ID: <878qdyeyuj.fsf@kernel.org> (raw)
In-Reply-To: <8B248539-70F3-4442-A8EB-33F10FDDE137@collabora.com>
"Daniel Almeida" <daniel.almeida@collabora.com> writes:
>> On 15 Jan 2026, at 16:03, Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
>>
>> On Thu, Jan 15, 2026 at 2:45 PM Daniel Almeida
>> <daniel.almeida@collabora.com> wrote:
>>>
>>> The flags may be in your uapi or they may otherwise come from C. In that case
>>> you’re stuck with a TryFrom or a manual conversion.
>>>
>>> I think a generated TryFrom shouldn't hurt. Just my 0.02c.
>>
>> I would say let's land this patch as-is (with the doc bit I mentioned)
>> and then we can discuss additions on top independently.
>
> Sure, that is also fine.
>
> Thanks for all the work, Filipe :)
Absolutely, I did not intend to stall this series. Just suggestions for
future work.
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2026-01-16 9:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2JpjX5S1c2QLiHUftMzVViS7xatVGkJperCPqxJU8ZQ_Opyo4KPge5jcRCPb0Gcgyxb4yeFhm6Y-1X8q3pbNaw==@protonmail.internalid>
2026-01-11 13:32 ` [PATCH v8] rust: add new macro for common bitflag operations Filipe Xavier
2026-01-11 20:06 ` Miguel Ojeda
2026-01-11 21:47 ` Filipe Xavier
2026-01-15 12:09 ` Andreas Hindborg
2026-01-15 12:14 ` Andreas Hindborg
2026-01-15 12:49 ` Andreas Hindborg
2026-01-15 13:19 ` Gary Guo
2026-01-15 13:31 ` Andreas Hindborg
2026-01-15 13:45 ` Daniel Almeida
2026-01-15 19:03 ` Miguel Ojeda
2026-01-15 19:13 ` Daniel Almeida
2026-01-16 8:38 ` Andreas Hindborg [this message]
2026-01-15 13:39 ` Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qdyeyuj.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=felipe_life@live.com \
--cc=felipeaggger@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.