From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13BB121D3F8 for ; Mon, 8 Dec 2025 14:50:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765205413; cv=none; b=NJ8G9MDQv26cephAK4gjOutL9I/2VGlbMqd+ZqS8wKgCqDz5j92ROZjiNccgg5DD3+TInHMbsJCH90vWzB1hu6UGsgV0YBd8B4qCdhtkIe48pmC7cF9izIjw6E1bmfikkWL5BjWCrWy6QtTDVcZjsyu6mAGLHhRJWMA+h/IGPIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765205413; c=relaxed/simple; bh=oLcJcrT5F+Vr/8sunLu2OqfKkra8TUpIXVZSvc7rTdU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=jQJ+Tu3FgQGyY3xUq9EfdFNlGR/wY2qxQVw2VZQXOB9Sg8yU9XVlOubgbcdc2CIzwAa4z7g5x3KY4XUFv3hZmkTAn+wNuq1Qck9qwa5vVcpYNYx53Fo9shwfzWos9bs8STXHZmPbzT3sXAAjnR9WbkzY7/c3y1T2yeC+jAnJEmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=H/zJocdL; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=NvU0tEL4; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="H/zJocdL"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="NvU0tEL4" From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1765205409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oLcJcrT5F+Vr/8sunLu2OqfKkra8TUpIXVZSvc7rTdU=; b=H/zJocdLG8mGXIJdCPaJBaK4kbiTTrEnlaF9TkxZMZDsf7+Ay0SAvSbTlPGpJZl+prB1zz elSvEs9AzlrBT/JdIy90tBpYT6Wu7FuI7Btg97v8/FHTdJ8nq7nkdRCitZRDWpYFWPzFzP 3uCr7KcIdCuq/7z1EbaScLmgKg6oNPGaYmj+ZS3X5waHnxa7uaKAKsQQqKKzN2YohjU9Ur f13+0RBR34t7pFwN9paKgC4vn3rakA5RYaYnhR4sFD54S8PoDnrd0BbE2+0YI7G9+eUKJF /Wy67afVCScDwVA7fd8qu+T+Pw4A6fFadrVaPQmCFxv5K590iOjjHL0gdJV7xQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1765205409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oLcJcrT5F+Vr/8sunLu2OqfKkra8TUpIXVZSvc7rTdU=; b=NvU0tEL4OHxz6DvyPCxsFef8cpz3jCNSDFd+SnS5agNA+Cyf94ipmv2hds69DdSv6rWo8b kFmNqNWUut5cFcBg== To: Marcos Paulo de Souza , Petr Mladek , Steven Rostedt , Sergey Senozhatsky Cc: linux-kernel@vger.kernel.org, marcos@mpdesouza.com, Marcos Paulo de Souza Subject: Re: [PATCH v2] printk: nbcon: Check for device_{lock,unlock} callbacks In-Reply-To: <20251208-nbcon-device-cb-fix-v2-1-36be8d195123@suse.com> References: <20251208-nbcon-device-cb-fix-v2-1-36be8d195123@suse.com> Date: Mon, 08 Dec 2025 15:56:08 +0106 Message-ID: <878qfdvxi7.fsf@jogness.linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 2025-12-08, Marcos Paulo de Souza wrote: > These callbacks are necessary to synchronize ->write_thread callback > against other operations using the same device. > > Signed-off-by: Marcos Paulo de Souza > --- > I found this issue while creating a custom kernel module that implements > the nbcon interfaces. > --- > Changes in v2: > - Merged the checks device locks with write_thread check, suggested by John. > - Link to v1: https://patch.msgid.link/20251205-nbcon-device-cb-fix-v1-1-906bdff5760b@suse.com > --- Thanks! Reviewed-by: John Ogness