All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Dave Hansen <dave.hansen@intel.com>,
	Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Dan Williams <dan.j.williams@intel.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/10] dmaengine: idxd: Fix lockdep warnings when calling idxd_device_config()
Date: Tue, 21 Oct 2025 16:33:26 -0700	[thread overview]
Message-ID: <878qh3keyh.fsf@intel.com> (raw)
In-Reply-To: <c7a454f4-c471-49d5-ac35-5375a45a6610@intel.com>

Hi,

Dave Hansen <dave.hansen@intel.com> writes:

> On 8/21/25 15:59, Vinicius Costa Gomes wrote:
>> Move the check for IDXD_FLAG_CONFIGURABLE and the locking to "inside"
>> idxd_device_config(), as this is common to all callers, and the one
>> that wasn't holding the lock was an error (that was causing the
>> lockdep warning).
>
> What is "the lockdep error"? I don't see any details about an error in
> the changelog here or the cover letter?

I should have added the lockdep splat here, idxd_reset_done() is calling
idxd_device_config() without holding the lock, and the lockdep assert
inside idxd_device_config() complains about that.

I thought the commit message ("one wasn't holding") and the code would
be clear enough. In case of a another version the series, I will add the
information here.


Cheers,
-- 
Vinicius

  reply	other threads:[~2025-10-21 23:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21 22:59 [PATCH v2 00/10] dmaengine: idxd: Memory leak and FLR fixes Vinicius Costa Gomes
2025-08-21 22:59 ` [PATCH v2 01/10] dmaengine: idxd: Fix lockdep warnings when calling idxd_device_config() Vinicius Costa Gomes
2025-08-21 23:05   ` Dave Jiang
2025-10-21 23:03   ` Dave Hansen
2025-10-21 23:33     ` Vinicius Costa Gomes [this message]
2025-08-21 22:59 ` [PATCH v2 02/10] dmaengine: idxd: Fix crash when the event log is disabled Vinicius Costa Gomes
2025-08-21 22:59 ` [PATCH v2 03/10] dmaengine: idxd: Fix possible invalid memory access after FLR Vinicius Costa Gomes
2025-08-21 22:59 ` [PATCH v2 04/10] dmaengine: idxd: Flush kernel workqueues on Function Level Reset Vinicius Costa Gomes
2025-08-21 23:12   ` Dave Jiang
2025-08-21 22:59 ` [PATCH v2 05/10] dmaengine: idxd: Flush all pending descriptors Vinicius Costa Gomes
2025-08-21 23:14   ` Dave Jiang
2025-08-21 22:59 ` [PATCH v2 06/10] dmaengine: idxd: Wait for submitted operations on .device_synchronize() Vinicius Costa Gomes
2025-08-21 23:14   ` Dave Jiang
2025-08-21 22:59 ` [PATCH v2 07/10] dmaengine: idxd: Fix not releasing workqueue on .release() Vinicius Costa Gomes
2025-08-21 22:59 ` [PATCH v2 08/10] dmaengine: idxd: Fix memory leak when a wq is reset Vinicius Costa Gomes
2025-08-21 22:59 ` [PATCH v2 09/10] dmaengine: idxd: Fix freeing the allocated ida too late Vinicius Costa Gomes
2025-08-21 22:59 ` [PATCH v2 10/10] dmaengine: idxd: Fix leaking event log memory Vinicius Costa Gomes
2025-10-21  1:06 ` [PATCH v2 00/10] dmaengine: idxd: Memory leak and FLR fixes Vinicius Costa Gomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qh3keyh.fsf@intel.com \
    --to=vinicius.gomes@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.