Re: Some unpriv verifier tests failed due to bpf_jit_bypass_spec_v1

[Luis Gerhorst <luis.gerhorst@fau.de>]

Hengqi Chen <hengqi.chen@gmail.com> writes:

> Some unpriv verifier tests (e.g. bounds_map_value_variant_2) failed
> on LoongArch which implements bpf_jit_bypass_spec_v1().
>
> This is because some verifier paths do can_skip_alu_sanitation().
> So for such cases, the priv/unpriv test cases will have the same
> verifier error messages and the tests failed with unexpected error
> messages.
>
> How can we fix them?

Please excuse the late reply.

The most simple fix would be to add the missing '#ifdef SPEC_V1' to
these tests, however, I anyway intend to send a new version of [1] which
removes some of these errors altogether. The patch did not get merged
with the rest of the series earlier because there was a merge conflict
with another fix (now resolved).

I ran the CI with bypass_spec_v1 set for x86 to reproduce your issue [2]
and the patch fixes some of the tests as expected [3]. Can you confirm
this is the same for LoongArch?

Some test still fail because the '#ifdef SPEC_V1' is still missing for
them. I will prepare a patch to resolve this.

[1] https://lore.kernel.org/all/CAADnVQLC_zViaCs5Huu63Jr2oCx1NGY3f_VCkJhrKvqst7HL=g@mail.gmail.com/
[2] https://github.com/kernel-patches/bpf/pull/9929
[3] https://github.com/kernel-patches/bpf/pull/9927