From: Nick Alcock <nick.alcock@oracle.com>
To: Kris Van Hees <kris.van.hees@oracle.com>
Cc: Nick Alcock <nick.alcock@oracle.com>, <dtrace@lists.linux.dev>,
<dtrace-devel@oss.oracle.com>
Subject: Re: [PATCH 2/4] provider, cg: add reject_clasue() callback
Date: Wed, 16 Jul 2025 11:53:41 +0100 [thread overview]
Message-ID: <878qkoqudm.fsf@esperi.org.uk> (raw)
In-Reply-To: <aHZvdMdtZ2DU27TN@oracle.com> (Kris Van Hees's message of "Tue, 15 Jul 2025 11:10:44 -0400")
On 15 Jul 2025, Kris Van Hees outgrape:
> On Tue, Jul 15, 2025 at 11:35:23AM +0100, Nick Alcock wrote:
>> > + /*
>> > + * Ensure the clause is valid for the probe. Call the reject_clause()
>> > + * hook if defined, otherwise apply default checks. Rejection of the
>> > + * clause must be reported as a compilation error.
>> > + */
>> > + if (prp->prov->impl->reject_clause != NULL)
>> > + prp->prov->impl->reject_clause(prp, sdp->dtsd_clauseflags);
>>
>> This change applies default checks *and* the reject_clause() checks, if
>> any, not one or the other.
>
> Well, actually, the comment needs updating because with this patch there is
> no default yet.
Yeah, you might as well fix what confused me :)
--
NULL && (void)
next prev parent reply other threads:[~2025-07-16 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 5:48 [PATCH 2/4] provider, cg: add reject_clasue() callback Kris Van Hees
2025-07-15 10:35 ` Nick Alcock
2025-07-15 15:10 ` Kris Van Hees
2025-07-16 10:53 ` Nick Alcock [this message]
2025-07-15 18:34 ` [DTrace-devel] " Eugene Loh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qkoqudm.fsf@esperi.org.uk \
--to=nick.alcock@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=kris.van.hees@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.