From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76936C83013 for ; Wed, 2 Jul 2025 07:49:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F/hADb0fyWY1KlmuJxakEaps1/var8rhUs5piLKVvVM=; b=0vELLXbTv/1hRK GX5MYTDtSPXkleaNJcdqYn5wHzDisSfU9tTaq/xFOn/5OL4vrCL4AaAd+KM23vomQmYWW+m7JMyfT LeygYhQzEvf8PcOgA/t+E6slVWNzHrGjXvJgeX4UB/Lyb6UoQtRduTojVo81TY7JebWPtPqi9FZNG PyJTM3VkuxkKvcXIGlovJWc4cGx4YQQSUJZ1AIO+QtaXIOBr7GkaMCsF0Njt/dBosQOlUqfTek6ie I/7vR8ugQKetL46kWKnocpcj33+ImEefj88DTDgP3vCVWC8yk/lqj7ZGQSEf5IOHx1m1QFrzDOGqh YEJ+XYHg69aq30D6H9ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWsDP-00000007XOi-3vFq; Wed, 02 Jul 2025 07:49:11 +0000 Received: from relay16.mail.gandi.net ([2001:4b98:dc4:8::236]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWsCS-00000007XI4-2cPe for linux-mtd@lists.infradead.org; Wed, 02 Jul 2025 07:48:14 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id DE69F449E7; Wed, 2 Jul 2025 07:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1751442489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FjGikRjaB+jO1uDjOO0DjL+ti5fz5Aw/2bvXKkr4ak4=; b=OwIxVvlZy5LxGK4FXI4zX/t+d9G0wKbfB3U8Du/5RVNNCOyIa38P4SPyY4yBlpGZ0AC9eL voNgIzfSQEqP9qLa22x2wjPykl46YEIiuh2Xhupo51qzUmXzQi9utPiCazlbQ0iBeisnwp PtNYqJrFh3cKII6ij0iu433zX+5tI4lDnGB8gbi2nrT3zLcnSBzU+uPZR/VYlj8oOGastt 9djwEeNezT70Ce0uxU8q7VTUqlYJdUg5h3rhlnOYbm6soUg31p1st1hbV7LlF2AwX1tmT6 BkSnHpqmNsPi04gOg99iBjZcks1yGSLDZ2mPVlRFsTG+JGP2zbjrLxpHQenowg== From: Miquel Raynal To: Thomas Fourier Cc: stable@vger.kernel.org, Richard Weinberger , Vignesh Raghavendra , Wolfram Sang , linux-mtd@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: renesas: Add missing check after DMA map In-Reply-To: <20250702071722.24921-3-fourier.thomas@gmail.com> (Thomas Fourier's message of "Wed, 2 Jul 2025 09:17:22 +0200") References: <20250702071722.24921-3-fourier.thomas@gmail.com> User-Agent: mu4e 1.12.7; emacs 30.1 Date: Wed, 02 Jul 2025 09:48:07 +0200 Message-ID: <878ql7nidk.fsf@bootlin.com> MIME-Version: 1.0 X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduieekfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghffgffkfggtgfgsehtqhertddtreejnecuhfhrohhmpefoihhquhgvlhcutfgrhihnrghluceomhhiqhhuvghlrdhrrgihnhgrlhessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepffeghfejtdefieeguddukedujeektdeihfelleeuieeuveehkedvleduheeivdefnecukfhppeeltddrkeelrdduieefrdduvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledtrdekledrudeifedruddvjedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhiqhhuvghlrdhrrgihnhgrlhessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepkedprhgtphhtthhopehfohhurhhivghrrdhthhhomhgrshesghhmrghilhdrtghomhdprhgtphhtthhopehsthgrsghlvgesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehrihgthhgrrhgusehnohgurdgrthdprhgtphhtthhopehvihhgnhgvshhhrhesthhirdgtohhmpdhrtghpthhtohepfihsrgdorhgvnhgvshgrshesshgrnhhgqdgvnhhgihhnvggvrhhinhhgrdgtohhmpdhrtghpt hhtoheplhhinhhugidqmhhtugeslhhishhtshdrihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehlihhnuhigqdhrvghnvghsrghsqdhsohgtsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250702_004813_113737_F3FCA1FD X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgVGhvbWFzLAoKT24gMDIvMDcvMjAyNSBhdCAwOToxNzoyMiArMDIsIFRob21hcyBGb3VyaWVy IDxmb3VyaWVyLnRob21hc0BnbWFpbC5jb20+IHdyb3RlOgoKPiBUaGUgRE1BIG1hcCBmdW5jdGlv bnMgY2FuIGZhaWwgYW5kIHNob3VsZCBiZSB0ZXN0ZWQgZm9yIGVycm9ycy4KPgo+IEZpeGVzOiBk ODcwMWZlODkwZWMgKCJtdGQ6IHJhd25hbmQ6IHJlbmVzYXM6IEFkZCBuZXcgTkFORCBjb250cm9s bGVyIGRyaXZlciIpCj4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcKPiBTaWduZWQtb2ZmLWJ5 OiBUaG9tYXMgRm91cmllciA8Zm91cmllci50aG9tYXNAZ21haWwuY29tPgo+IC0tLQo+ICBkcml2 ZXJzL210ZC9uYW5kL3Jhdy9yZW5lc2FzLW5hbmQtY29udHJvbGxlci5jIHwgOCArKysrKysrKwo+ ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9tdGQvbmFuZC9yYXcvcmVuZXNhcy1uYW5kLWNvbnRyb2xsZXIuYyBiL2RyaXZlcnMvbXRkL25h bmQvcmF3L3JlbmVzYXMtbmFuZC1jb250cm9sbGVyLmMKPiBpbmRleCA0NGY2NjAzNzM2ZDEuLmY0 YTc3NTU3MTczMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9yZW5lc2FzLW5h bmQtY29udHJvbGxlci5jCj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvcmVuZXNhcy1uYW5k LWNvbnRyb2xsZXIuYwo+IEBAIC00MjYsNiArNDI2LDEwIEBAIHN0YXRpYyBpbnQgcm5hbmRjX3Jl YWRfcGFnZV9od19lY2Moc3RydWN0IG5hbmRfY2hpcCAqY2hpcCwgdTggKmJ1ZiwKPiAgCS8qIENv bmZpZ3VyZSBETUEgKi8KPiAgCWRtYV9hZGRyID0gZG1hX21hcF9zaW5nbGUocm5hbmRjLT5kZXYs IHJuYW5kYy0+YnVmLCBtdGQtPndyaXRlc2l6ZSwKPiAgCQkJCSAgRE1BX0ZST01fREVWSUNFKTsK PiArCWlmIChkbWFfbWFwcGluZ19lcnJvcihybmFuZGMtPmRldiwgZG1hX2FkZHIpKSB7Cj4gKwkJ ZGV2X2VycihybmFuZGMtPmRldiwgIkRNQSBtYXBwaW5nIGZhaWxlZC5cbiIpOwoKVGhpcyBlcnJv ciBtZXNzYWdlIGlzIG5vdCBpbmZvcm1hdGl2ZSwgcGxlYXNlIGRyb3AKaXQuIGRtYV9tYXBwaW5n X2Vycm9yKCkgZG9lcyBnaXZlIG1vcmUgaW5mb3JtYXRpb24gaWYgeW91IGVuYWJsZSBzb21lCkRN QSBERUJVRyBLY29uZmlnIHN5bWJvbCBhbHJlYWR5LgoKPiArCQlyZXR1cm4gLUVOT01FTTsKPiAr CX0KPiAgCXdyaXRlbChkbWFfYWRkciwgcm5hbmRjLT5yZWdzICsgRE1BX0FERFJfTE9XX1JFRyk7 Cj4gIAl3cml0ZWwobXRkLT53cml0ZXNpemUsIHJuYW5kYy0+cmVncyArIERNQV9DTlRfUkVHKTsK PiAgCXdyaXRlbChETUFfVExWTF9NQVgsIHJuYW5kYy0+cmVncyArIERNQV9UTFZMX1JFRyk7Cj4g QEAgLTYwNiw2ICs2MTAsMTAgQEAgc3RhdGljIGludCBybmFuZGNfd3JpdGVfcGFnZV9od19lY2Mo c3RydWN0IG5hbmRfY2hpcCAqY2hpcCwgY29uc3QgdTggKmJ1ZiwKPiAgCS8qIENvbmZpZ3VyZSBE TUEgKi8KPiAgCWRtYV9hZGRyID0gZG1hX21hcF9zaW5nbGUocm5hbmRjLT5kZXYsICh2b2lkICop cm5hbmRjLT5idWYsIG10ZC0+d3JpdGVzaXplLAo+ICAJCQkJICBETUFfVE9fREVWSUNFKTsKPiAr CWlmIChkbWFfbWFwcGluZ19lcnJvcihybmFuZGMtPmRldiwgZG1hX2FkZHIpKSB7Cj4gKwkJZGV2 X2VycihybmFuZGMtPmRldiwgIkRNQSBtYXBwaW5nIGZhaWxlZC5cbiIpOwoKRGl0dG8uCgo+ICsJ CXJldHVybiAtRU5PTUVNOwo+ICsJfQo+ICAJd3JpdGVsKGRtYV9hZGRyLCBybmFuZGMtPnJlZ3Mg KyBETUFfQUREUl9MT1dfUkVHKTsKPiAgCXdyaXRlbChtdGQtPndyaXRlc2l6ZSwgcm5hbmRjLT5y ZWdzICsgRE1BX0NOVF9SRUcpOwo+ICAJd3JpdGVsKERNQV9UTFZMX01BWCwgcm5hbmRjLT5yZWdz ICsgRE1BX1RMVkxfUkVHKTsKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1h aWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay16.mail.gandi.net (relay16.mail.gandi.net [217.70.178.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C694E223DEA; Wed, 2 Jul 2025 07:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.178.236 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751442500; cv=none; b=LLddxLg/9KtETc4IOilizR4HMUXLjRLq5cXficerztI2/SQaWsP3vzjMI97iYzpJ3gU/cORx+vd3O2atbh8Mq3dbPMYKPVcZiozO8OWm6WwtZxJ1ApxcPbPpbY17tbh3xBQ2NbPEqTCH5BwWR6dawnOmDKrIslnsCPzWc+jZdtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751442500; c=relaxed/simple; bh=Ygo+3EXyX2A//CA0ixDyqzlihUEypIyuHoFDa84UCtQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=NEt680OTWTJWP8HJcynwLLeQ0dlltLgL+VaxdPsx3q/OXn7mSLYfuVQKpvg2stlaDdKsfThF6tbLRZN9+28pf73KEMOQ5Tz7QdbCF3y/0orzODRdSAa+oXpvL9c+uVUyvcyJiL9zhNgt42uczzI6v7Yl9ZKYkRO+svqJshFyY+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=OwIxVvlZ; arc=none smtp.client-ip=217.70.178.236 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="OwIxVvlZ" Received: by mail.gandi.net (Postfix) with ESMTPSA id DE69F449E7; Wed, 2 Jul 2025 07:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1751442489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FjGikRjaB+jO1uDjOO0DjL+ti5fz5Aw/2bvXKkr4ak4=; b=OwIxVvlZy5LxGK4FXI4zX/t+d9G0wKbfB3U8Du/5RVNNCOyIa38P4SPyY4yBlpGZ0AC9eL voNgIzfSQEqP9qLa22x2wjPykl46YEIiuh2Xhupo51qzUmXzQi9utPiCazlbQ0iBeisnwp PtNYqJrFh3cKII6ij0iu433zX+5tI4lDnGB8gbi2nrT3zLcnSBzU+uPZR/VYlj8oOGastt 9djwEeNezT70Ce0uxU8q7VTUqlYJdUg5h3rhlnOYbm6soUg31p1st1hbV7LlF2AwX1tmT6 BkSnHpqmNsPi04gOg99iBjZcks1yGSLDZ2mPVlRFsTG+JGP2zbjrLxpHQenowg== From: Miquel Raynal To: Thomas Fourier Cc: stable@vger.kernel.org, Richard Weinberger , Vignesh Raghavendra , Wolfram Sang , linux-mtd@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: renesas: Add missing check after DMA map In-Reply-To: <20250702071722.24921-3-fourier.thomas@gmail.com> (Thomas Fourier's message of "Wed, 2 Jul 2025 09:17:22 +0200") References: <20250702071722.24921-3-fourier.thomas@gmail.com> User-Agent: mu4e 1.12.7; emacs 30.1 Date: Wed, 02 Jul 2025 09:48:07 +0200 Message-ID: <878ql7nidk.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduieekfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghffgffkfggtgfgsehtqhertddtreejnecuhfhrohhmpefoihhquhgvlhcutfgrhihnrghluceomhhiqhhuvghlrdhrrgihnhgrlhessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepffeghfejtdefieeguddukedujeektdeihfelleeuieeuveehkedvleduheeivdefnecukfhppeeltddrkeelrdduieefrdduvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledtrdekledrudeifedruddvjedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhiqhhuvghlrdhrrgihnhgrlhessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepkedprhgtphhtthhopehfohhurhhivghrrdhthhhomhgrshesghhmrghilhdrtghomhdprhgtphhtthhopehsthgrsghlvgesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehrihgthhgrrhgusehnohgurdgrthdprhgtphhtthhopehvihhgnhgvshhhrhesthhirdgtohhmpdhrtghpthhtohepfihsrgdorhgvnhgvshgrshesshgrnhhgqdgvnhhgihhnvggvrhhinhhgrdgtohhmpdhrtghpt hhtoheplhhinhhugidqmhhtugeslhhishhtshdrihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehlihhnuhigqdhrvghnvghsrghsqdhsohgtsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg Hi Thomas, On 02/07/2025 at 09:17:22 +02, Thomas Fourier wr= ote: > The DMA map functions can fail and should be tested for errors. > > Fixes: d8701fe890ec ("mtd: rawnand: renesas: Add new NAND controller driv= er") > Cc: stable@vger.kernel.org > Signed-off-by: Thomas Fourier > --- > drivers/mtd/nand/raw/renesas-nand-controller.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mtd/nand/raw/renesas-nand-controller.c b/drivers/mtd= /nand/raw/renesas-nand-controller.c > index 44f6603736d1..f4a775571733 100644 > --- a/drivers/mtd/nand/raw/renesas-nand-controller.c > +++ b/drivers/mtd/nand/raw/renesas-nand-controller.c > @@ -426,6 +426,10 @@ static int rnandc_read_page_hw_ecc(struct nand_chip = *chip, u8 *buf, > /* Configure DMA */ > dma_addr =3D dma_map_single(rnandc->dev, rnandc->buf, mtd->writesize, > DMA_FROM_DEVICE); > + if (dma_mapping_error(rnandc->dev, dma_addr)) { > + dev_err(rnandc->dev, "DMA mapping failed.\n"); This error message is not informative, please drop it. dma_mapping_error() does give more information if you enable some DMA DEBUG Kconfig symbol already. > + return -ENOMEM; > + } > writel(dma_addr, rnandc->regs + DMA_ADDR_LOW_REG); > writel(mtd->writesize, rnandc->regs + DMA_CNT_REG); > writel(DMA_TLVL_MAX, rnandc->regs + DMA_TLVL_REG); > @@ -606,6 +610,10 @@ static int rnandc_write_page_hw_ecc(struct nand_chip= *chip, const u8 *buf, > /* Configure DMA */ > dma_addr =3D dma_map_single(rnandc->dev, (void *)rnandc->buf, mtd->writ= esize, > DMA_TO_DEVICE); > + if (dma_mapping_error(rnandc->dev, dma_addr)) { > + dev_err(rnandc->dev, "DMA mapping failed.\n"); Ditto. > + return -ENOMEM; > + } > writel(dma_addr, rnandc->regs + DMA_ADDR_LOW_REG); > writel(mtd->writesize, rnandc->regs + DMA_CNT_REG); > writel(DMA_TLVL_MAX, rnandc->regs + DMA_TLVL_REG); Thanks, Miqu=C3=A8l