All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Pablo MARTIN-GOMEZ <pmartin-gomez@freebox.fr>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,  linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: spinand: fix memory leak of ECC engine conf
Date: Wed, 18 Jun 2025 11:10:05 +0200	[thread overview]
Message-ID: <878qlpmn4i.fsf@bootlin.com> (raw)
In-Reply-To: <e56ab56f-9ceb-4c95-a134-ad7186951b34@freebox.fr> (Pablo MARTIN-GOMEZ's message of "Mon, 9 Jun 2025 20:02:08 +0200")

Hi Pablo,

On 09/06/2025 at 20:02:08 +02, Pablo MARTIN-GOMEZ <pmartin-gomez@freebox.fr> wrote:

> Memory allocated for the ECC engine conf is not released during spinand
> cleanup. Below kmemleak trace is seen for this memory leak:
>
> unreferenced object 0xffffff80064f00e0 (size 8):
>   comm "swapper/0", pid 1, jiffies 4294937458
>   hex dump (first 8 bytes):
>     00 00 00 00 00 00 00 00                          ........
>   backtrace (crc 0):
>     kmemleak_alloc+0x30/0x40
>     __kmalloc_cache_noprof+0x208/0x3c0
>     spinand_ondie_ecc_init_ctx+0x114/0x200
>     nand_ecc_init_ctx+0x70/0xa8
>     nanddev_ecc_engine_init+0xec/0x27c
>     spinand_probe+0xa2c/0x1620
>     spi_mem_probe+0x130/0x21c
>     spi_probe+0xf0/0x170
>     really_probe+0x17c/0x6e8
>     __driver_probe_device+0x17c/0x21c
>     driver_probe_device+0x58/0x180
>     __device_attach_driver+0x15c/0x1f8
>     bus_for_each_drv+0xec/0x150
>     __device_attach+0x188/0x24c
>     device_initial_probe+0x10/0x20
>     bus_probe_device+0x11c/0x160
>
> Fix the leak by calling nanddev_ecc_engine_cleanup() inside
> spinand_cleanup().
>
> Signed-off-by: Pablo Martin-Gomez <pmartin-gomez@freebox.fr>

This patch no longer applies on v6.16-rc1, can you please rebase and
resend ?

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2025-06-18  9:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 18:02 [PATCH] mtd: spinand: fix memory leak of ECC engine conf Pablo MARTIN-GOMEZ
2025-06-18  9:10 ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qlpmn4i.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=pmartin-gomez@freebox.fr \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.