From: Takashi Iwai <tiwai@suse.de>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] ALSA: hda/cs35l56: Remove dependency on COMPILE_TEST
Date: Wed, 30 Apr 2025 07:35:29 +0200 [thread overview]
Message-ID: <878qnidxem.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250428094126.125781-1-rf@opensource.cirrus.com>
On Mon, 28 Apr 2025 11:41:26 +0200,
Richard Fitzgerald wrote:
>
> Change the Kconfig dependency on ACPI || COMPILE_TEST to only depend on
> ACPI.
>
> The alternate dependency on COMPILE_TEST was a fudge to enable building
> KUnit tests for modules that are selected by the CS35L56 driver but don't
> depend on ACPI. This was based on a misunderstanding that KUNIT_ALL_TESTS
> meant "all tests". Actually KUNIT_ALL_TESTS only means "tests for modules
> that have satisfied dependencies" so it shouldn't be overriding
> dependencies.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2025-04-30 5:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 9:41 [PATCH] ALSA: hda/cs35l56: Remove dependency on COMPILE_TEST Richard Fitzgerald
2025-04-30 5:35 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qnidxem.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.