From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03090C3600B for ; Thu, 27 Mar 2025 11:30:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 71FEB10E8AD; Thu, 27 Mar 2025 11:30:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="V9JjrSIv"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id C154110E8AD for ; Thu, 27 Mar 2025 11:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743075037; x=1774611037; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=Qc/3JRNQJZPBUGMXBMeweJVuwNQCbZyCZGpCnOH/KwQ=; b=V9JjrSIvHk8dSSsfVEdRp0yL2klzr13x/XtYt8Hh7s+QW7uOUI3WjAiF LLX+As+B7LLpyap/3QLlxtrxQ4IHs2Qmz48+UGHGnqVtB5g8T1qmguohI cZdm1hrKA+UZGporcskSWFwT+iZUrkVxlXexy2i0TPkpusTIbDZIuVohb jx0SV37hGk6kA8HmghgK0TBzV8wVkiCnzum63291iWjYH1XCVOGo8OIqN NS04njmYOsRehL5dfI92nfjx3HC6GIEXuMpw4/GMwWgAj5k6OJ4Uo1Qqp ELy51bjccvKSc1XhI/MZHuTKCMq2ihUytnFBvtvk4VH6WTCZy1Q5u5u83 Q==; X-CSE-ConnectionGUID: DzNwu7hkTfSAVUP0KCuL2g== X-CSE-MsgGUID: ra/OOfaMTpKdOT9j33VsrQ== X-IronPort-AV: E=McAfee;i="6700,10204,11385"; a="44319496" X-IronPort-AV: E=Sophos;i="6.14,280,1736841600"; d="scan'208";a="44319496" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2025 04:30:37 -0700 X-CSE-ConnectionGUID: GPi8BeiwRza7ifQ7HSdZ4g== X-CSE-MsgGUID: N1Pn7sK6SHmb15gV7Wys2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,280,1736841600"; d="scan'208";a="125326710" Received: from ncintean-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.17]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2025 04:30:33 -0700 From: Jani Nikula To: Boris Brezillon , dri-devel@lists.freedesktop.org Cc: Boris Brezillon , kernel@collabora.com, Dmitry Osipenko , Jacek Lawrynowicz , Maciej Falkowski , Oded Gabbay Subject: Re: [PATCH 1/3] accel/ivpu: pages_use_count is now a refcount_t In-Reply-To: <20250327104300.1982058-1-boris.brezillon@collabora.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250327104300.1982058-1-boris.brezillon@collabora.com> Date: Thu, 27 Mar 2025 13:30:30 +0200 Message-ID: <878qoq678p.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 27 Mar 2025, Boris Brezillon wrote: > Commit 051b6646d36d ("drm/shmem-helper: Use refcount_t for > pages_use_count") changed the type of > drm_gem_shmem_object::pages_use_count but accel drivers were left > behind. > > Fixes: 051b6646d36d ("drm/shmem-helper: Use refcount_t for pages_use_count") > Signed-off-by: Boris Brezillon > Cc: Dmitry Osipenko > Cc: Jacek Lawrynowicz > Cc: Maciej Falkowski > Cc: Oded Gabbay > Cc: dri-devel@lists.freedesktop.org Just for build, on the series, Tested-by: Jani Nikula Please merge. > --- > drivers/accel/ivpu/ivpu_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c > index 8741c73b92ce..09c9c5256af5 100644 > --- a/drivers/accel/ivpu/ivpu_gem.c > +++ b/drivers/accel/ivpu/ivpu_gem.c > @@ -282,7 +282,7 @@ static void ivpu_gem_bo_free(struct drm_gem_object *obj) > ivpu_bo_unbind_locked(bo); > mutex_destroy(&bo->lock); > > - drm_WARN_ON(obj->dev, bo->base.pages_use_count > 1); > + drm_WARN_ON(obj->dev, refcount_read(&bo->base.pages_use_count) > 1); > drm_gem_shmem_free(&bo->base); > } -- Jani Nikula, Intel