From: Thomas Gleixner <tglx@linutronix.de>
To: Tsai Sung-Fu <danielsftsai@google.com>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Andrew Chant" <achant@google.com>,
"Brian Norris" <briannorris@google.com>,
"Sajid Dalvi" <sdalvi@google.com>,
"Mark Cheng" <markcheng@google.com>,
"Ben Cheng" <bccheng@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Marc Zyngier" <maz@kernel.org>
Subject: Re: [PATCH] PCI: dwc: Chain the set IRQ affinity request back to the parent
Date: Fri, 07 Mar 2025 20:49:38 +0100 [thread overview]
Message-ID: <878qpg4o4t.ffs@tglx> (raw)
In-Reply-To: <CAK7fddCG6-Q0s-jh5GE7LG+Kf6nON8u9BS4Ame9Xa7VF1=ujiw@mail.gmail.com>
On Fri, Mar 07 2025 at 19:10, Tsai Sung-Fu wrote:
> Thanks for your detailed explanation and feedback, I am a bit confused about the
> #4 you mentioned here ->
>
>> 4) Affinity of the demultiplex interrupt
>
> Are you saying there is a chance to queue this demultiplexing IRQ event
> to the current running CPU ?
The demultiplexing interrupt (currently a chained handler, which is
hidden from /proc/irq/) stays at the affinity which the kernel decided
to assign to it at startup. That means it can't be steered to a
particual CPU and nobody knows to which CPU it is affine. You can only
guess it from /proc/interrupts by observing where the associated
demultiplex interrupts are affine to.
So ideally you want to be able to affine the demultiplexing interrupt
too. That requires to switch it to a regular interrupt for
simplicity. We could expose those hidden chained handlers affinity too,
but that needs some surgery vs. locking etc.
> And that's really an approach worth to try, I will work on it.
I've played with this on top of variant of Marc's changes to use MSI
parent interrupts for such controllers too:
https://lore.kernel.org/all/20241204124549.607054-1-maz@kernel.org/
A completely untested and largely uncompiled preview is here:
https://tglx.de/~tglx/patches.tar
The MSI parent parts are in flux. Marc will look at them in the next
weeks, but I picked them up because it simplifies the whole business a
lot. If you find bugs in that series, you can keep them :)
Thanks,
tglx
next prev parent reply other threads:[~2025-03-07 19:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 7:05 [PATCH] PCI: dwc: Chain the set IRQ affinity request back to the parent Daniel Tsai
2025-03-03 9:10 ` Thomas Gleixner
2025-03-04 5:48 ` Tsai Sung-Fu
2025-03-04 9:46 ` Thomas Gleixner
2025-03-05 11:21 ` Tsai Sung-Fu
2025-03-06 7:44 ` Thomas Gleixner
2025-03-07 11:10 ` Tsai Sung-Fu
2025-03-07 19:49 ` Thomas Gleixner [this message]
2025-03-11 9:52 ` Tsai Sung-Fu
2025-03-11 14:05 ` Thomas Gleixner
2025-03-25 6:38 ` Tsai Sung-Fu
2025-05-07 11:10 ` Krishna Chaitanya Chundru
2025-03-03 9:25 ` kernel test robot
2025-03-03 10:13 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qpg4o4t.ffs@tglx \
--to=tglx@linutronix.de \
--cc=achant@google.com \
--cc=bccheng@google.com \
--cc=bhelgaas@google.com \
--cc=briannorris@google.com \
--cc=danielsftsai@google.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=markcheng@google.com \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=sdalvi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.