From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2087.outbound.protection.outlook.com [40.107.223.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16D911D9346 for ; Tue, 7 Jan 2025 12:05:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.87 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736251547; cv=fail; b=NVhdbtFlCJaRyEHBPi/HoR2i9ZJIBYGfwbPtdGEjboa2BMFJQWgONy6lP+0y8Ku8IQUAZgkDpkwij41KG2ouosO54rIjyO1l5P5iZeCr4XupF2ZVDSKXc4EjMKhLOu1vJS7rTXmfi4mJHp8A5uljm0FUQh4vWooVOkKaTHC0WxY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736251547; c=relaxed/simple; bh=d4q0GUq9YDmHTckM9QJILCKkoQrq/5f2sFXRUgDn7VM=; h=References:From:To:CC:Subject:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=XrG+y/MTl13xpo6Xc7BcBH1Kr8MnKG0WPBwaKuWgoANAPiBDhx7Y7IWtE+2F09ZMF7WAQYV6fJC8XtzuCJ4MTH+uvoTVH0tk0SM520pRsX5TjPvQ4N2J8inRowHFUjGLP0Rc7RTTiOpHXPn1qkMZwuF5+imQ3+1kHVO3e5EEurM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Bv1hcArF; arc=fail smtp.client-ip=40.107.223.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Bv1hcArF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cCgr0ZwcJOAcuP6XQZGJgxgajM8Okjzn0+xks4yJ7UNb+Euj/jM0EQFttgn7lrXyXBWvsQvu7ZMHH8Yy5KQFQqJkeXuQYDGTklgsBFg/J7b+3ZGvzZs8KZg+W3W9oETOZpRHEi7ronGYlB5wfkba5vjeYVSQZRsOEYgfCQhIU9i8B3vNvEk+JlcqAextxDd01nqjpTR7OTTcy5tmKEUGNnErCIMCFoItBLpzSAHsIuYDhIJv8ES59AZMnhymDc+jmPehyX0DFhNSI5X8gvsbnjHjyg2qqBExgabBsHBs2VQUW9M+ESKpq4Vu8vJacVR6QuXBqfd32siwzqoEYmCYgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0YUyZRWXIMPodU6jmb0I8uM72POu0w5hT+kd/sEYvF0=; b=cIwW6IJcdSxZwjBRuGqYBYE37QzsodQ4pdqrFPr2zDay12krIdu7C+MVi3rpUjU94oLgfJPdpXimPSMVlotLNuTkVvt2fniMiNKTHIszNRLUjgjl0eLEQfGd/Pq/LBDUsVqTi6bjOlk7OOsutk7etrgBLN160+tOaP62n+TXGr3mtD2yvZn7oadA1lFGUxX4/IUyzB5IWGqXQjmRrsjgkUKJXWEKKGoOEUblg7xiPj1RaR5tPMeLFOPYqkgK5YSbMv75NJOpguo9xW0jzB/RoEUsbWgZFIOaRwuYAso3NvmRKyANNknnMDmN+4TOsmy697IDyJI+TEKIvvwLq1gSlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0YUyZRWXIMPodU6jmb0I8uM72POu0w5hT+kd/sEYvF0=; b=Bv1hcArFaDTNmsk2w8saXsdYaz8Xc4cGGK1hVVNpCWenqxBEHzd3yHQwkZkpApDYlF+O+TSqVGu06XG31j2begdXhc+YLAcFYuSCzj06315tdBB0m8wvY1trFfroC8YVL8ml4qC4kvxzKpFitJGY50GwwLHV7VUGsHizg8LhL8q5M+DkT1O79EJ2hlm7tpMAQ0RsGOeULPG6ioAikSZ3SgjzPlciVTZApTi62akvJE0RgTM3GqekIyT0Dl+c81pRrXKKxaH4xoy8UyfWPzun8ka13JTBrdp/FMM3435WROqvTGQeoS6cJDG4jFvfK8FkLtJUJS9/XWbbAdHs1Hz5kQ== Received: from BL1PR13CA0087.namprd13.prod.outlook.com (2603:10b6:208:2b8::32) by CYYPR12MB8872.namprd12.prod.outlook.com (2603:10b6:930:c8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.10; Tue, 7 Jan 2025 12:05:40 +0000 Received: from BN2PEPF00004FBE.namprd04.prod.outlook.com (2603:10b6:208:2b8:cafe::f5) by BL1PR13CA0087.outlook.office365.com (2603:10b6:208:2b8::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8335.10 via Frontend Transport; Tue, 7 Jan 2025 12:05:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF00004FBE.mail.protection.outlook.com (10.167.243.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.7 via Frontend Transport; Tue, 7 Jan 2025 12:05:40 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 7 Jan 2025 04:05:25 -0800 Received: from fedora (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 7 Jan 2025 04:05:21 -0800 References: <20241217133430.342797-1-petrm@nvidia.com> User-agent: mu4e 1.8.14; emacs 29.4 From: Petr Machata To: Petr Machata CC: Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , , Andy Roulin Subject: Re: [PATCH] checkpatch: Tolerate upstream commit references Date: Tue, 7 Jan 2025 12:55:45 +0100 In-Reply-To: <20241217133430.342797-1-petrm@nvidia.com> Message-ID: <878qrmlthe.fsf@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF00004FBE:EE_|CYYPR12MB8872:EE_ X-MS-Office365-Filtering-Correlation-Id: 86b29427-5711-4239-626b-08dd2f139acb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?g2hASnwaWjyIZHfEaMF1xTEKp7nAzcKGciJ6jSUzRaZtIQU/ckGGKnTcE9eR?= =?us-ascii?Q?1gtsl+rmx4nwXsDBKYmIVsz4QepTwqzbi6of0ZoE9T4TCy/oNVbE7JHeBT6G?= =?us-ascii?Q?1o4B4vKL+9jkdC6cJbbaBPGAaFcmR96H4wwybkkb/9/dDx5fQUntPeHTnKU2?= =?us-ascii?Q?mx0gnKRue9SEJ72O+sl8qWVbwTHmxCyN7o3cRklVbHzsK/n3Umz4zRCkLL1p?= =?us-ascii?Q?/jpmK3PCFDQCZW3mbjM8YJQflsK6L1/IK2KQq1uVqVFDN+cUsIUtklQmlJtl?= =?us-ascii?Q?CzrbelKtNcM19YVdn8kAWZ8Mtj7uc29wwk64A7it9E2ybMrmwEuwlK5LKPDv?= =?us-ascii?Q?pjx1zoHcdGFSoKgZYWbzNgE+ltf1TbTVlG2hrLF3Kha+L2GWsoJCJ61/rhY5?= =?us-ascii?Q?6p5WycrefJOTGPnPAJ9y0H7WhwuJiaoFmflSgZce7CF4gs4BIClRVbgk4xZc?= =?us-ascii?Q?hlFL9Vctg4KDZDKjTuqyrE+mZCqD7/j/qInAcjVCuE+2/J65tQFiNXcrqIYO?= =?us-ascii?Q?HXrSyZdtXGK6aGNYoyqCC7Ji2BKQp8t+fEkc3sKr2qhmWfIK9IB95yFXdMTh?= =?us-ascii?Q?6E7i4VwuEAzT4+cq0S7eeX8wDGmD3SsIUK7T5rSNjcI2dTFxRnyNakV2Pklj?= =?us-ascii?Q?cbzF/WXefeyUwTnAZmi2J5HFORfet8f/gRToz/jsAdnduKHQBoWOEUUBZJQ5?= =?us-ascii?Q?P9wbE2N0Ls/bh8xjuBO38yiGunrim+T/4YvywtpBWne6/iCV7y25yxTegQJ7?= =?us-ascii?Q?xJhUCKxY7vshxjvi/nutuZ+Tl5VbIbV0kwWZNIJTReP9xC8GP9wXarpXkH8S?= =?us-ascii?Q?U+ZsvOzpuIF1HMhgzGNkwjBQpUejIvYt9+GHgKO8w6SVGD0cLTNyoczjwvHW?= =?us-ascii?Q?T9p81KmftsM6KFQhnMC2BWX7pAeuSYpDlAVTciBsg49Votg29CBPErFpDdUs?= =?us-ascii?Q?GniGh52BiSyMyCdxnPhGEDjwd8QeexI/W/vTcQqZV6IVWQvRs+Jmq2TSueMq?= =?us-ascii?Q?VZy8KvGytV333EhhY2YIzR/9yvCl2LZeLCAFGTs60MY+TUpHlMUOvgj35j/u?= =?us-ascii?Q?MMpQ+XOREv85VW/fzURCvQEaa7R3tfnWiRrqNDLufXz/C6TOXk5uiQ1aODv3?= =?us-ascii?Q?MnKKPy90nbDVLKvdJzyvvzrVUD4MpQM1HhT8A3xikZUb1ydMlZsFAIpsU7lR?= =?us-ascii?Q?FrFwP3eN6kgH8IiRXrdxZjq0yMx2yyphKdoKOd4Y7pOsuC+1XfvVhBosq/fs?= =?us-ascii?Q?by+26pWu7wCP4C6QR+5d3AiIX0PAYgQb2UPDbZJ0bOUlbsfyTBbSZT3BCwv7?= =?us-ascii?Q?Du+eDIESyJasNmo4eFS+9Q1U8W0PRJjP7DrlGoxsGYEdtuRga1Yt9+waxU3p?= =?us-ascii?Q?Heb7l4wB6iow4xSxg3tKUS2lMLcTV2YprmBPp59MlaQznY7od+pEVj15J+NY?= =?us-ascii?Q?N7aYz3BpFCMpUqlCvB3Q41YzKYZ0vm3kdYwdxZHZq3z+gByLakMww2qXkGXS?= =?us-ascii?Q?SoHEEinHMXYUocE=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2025 12:05:40.2507 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86b29427-5711-4239-626b-08dd2f139acb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF00004FBE.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8872 Petr Machata writes: > Two forms of upstream commit references are used (and documented) for > stable kernels: > > - [ Upstream commit ] > - commit upstream. > > These are useful apart from stable kernel trees to other downstream > maintainers that wish to keep track of what came from where. But > checkpatch gives citations on patches annotated this way. > > Extend checkpatch to tolerate the documented upstream references. This > reduces noise for downstream maintainers. > > Signed-off-by: Petr Machata > Reviewed-by: Andy Roulin Hello y'all all and happy 2025! I sent this towards the end of the year, and understandably people were busy around New Year's. This is to try and make sure the patch doesn't get lost in last year's mailing, and ask for a bit of an attention from maintainers. Thanks! > --- > scripts/checkpatch.pl | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 9eed3683ad76..a6c81b38e413 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -3340,6 +3340,8 @@ sub process { > if ($perl_version_ok && > $in_commit_log && !$commit_log_possible_stack_dump && > $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink|base-commit):/i && > + $line !~ /^\s*\[ Upstream commit [0-9a-f]{40} ]/ && > + $line !~ /^\s*commit [0-9a-f]{40}\s*upstream\./ && > $line !~ /^This reverts commit [0-9a-f]{7,40}/ && > (($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i || > ($line =~ /\bcommit\s*$/i && defined($rawlines[$linenr]) && $rawlines[$linenr] =~ /^\s*[0-9a-f]{5,}\b/i)) ||