Re: Patch "irqchip: Convert all platform MSI users to the new API" has been added to the 6.6-stable tree

[Thomas Gleixner <tglx@linutronix.de>]

On Wed, Dec 11 2024 at 13:39, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
>
>     irqchip: Convert all platform MSI users to the new API
>
> to the 6.6-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
>      irqchip-convert-all-platform-msi-users-to-the-new-ap.patch
> and it can be found in the queue-6.6 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
>
>
>
> commit 5df23ec861a0208ef524a27e44c694ca2decb7ea
> Author: Thomas Gleixner <tglx@linutronix.de>
> Date:   Sat Jan 27 21:47:34 2024 +0530
>
>     irqchip: Convert all platform MSI users to the new API
>     
>     [ Upstream commit 14fd06c776b5289a43c91cdc64bac3bdbc7b397e ]
>     
>     Switch all the users of the platform MSI domain over to invoke the new
>     interfaces which branch to the original platform MSI functions when the
>     irqdomain associated to the caller device does not yet provide MSI parent
>     functionality.
>     
>     No functional change.
>     
>     Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>     Signed-off-by: Anup Patel <apatel@ventanamicro.com>
>     Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>     Link: https://lore.kernel.org/r/20240127161753.114685-7-apatel@ventanamicro.com
>     Stable-dep-of: 64506b3d23a3 ("scsi: ufs: qcom: Only free platform MSIs when ESI is enabled")

This commit makes the invocation of

	platform_msi_domain_free_irqs_all(hba->dev);

conditional on

        if (host->esi_enabled)

The original code before 5df23ec861a0208ef524a27e44c694ca2decb7ea was:

        platform_msi_domain_free_irqs(hba->dev);

> @@ -1926,7 +1926,7 @@ static void ufs_qcom_remove(struct platform_device *pdev)
>  
>  	pm_runtime_get_sync(&(pdev)->dev);
>  	ufshcd_remove(hba);
> -	platform_msi_domain_free_irqs(hba->dev);
> +	platform_device_msi_free_irqs_all(hba->dev);
>  }

which means the whole backport is not required and just commit
64506b3d23a3 needs to be adjusted for pre 5df23ec861:

-	platform_msi_domain_free_irqs(hba->dev);
+	if (host->esi_enabled)
+		platform_msi_domain_free_irqs(hba->dev);

Thanks,

        tglx