From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Woodrow Douglass via buildroot <buildroot@buildroot.org>
Cc: Woodrow Douglass <wdouglass@carnegierobotics.com>
Subject: Re: [Buildroot] [PATCH] package/chicken: pass TARGET_CFLAGS to chicken build system explicitly
Date: Tue, 06 Aug 2024 17:26:39 +0300 [thread overview]
Message-ID: <878qx93exs.fsf@tarshish> (raw)
In-Reply-To: <20240806130553.981094-1-wdouglass@carnegierobotics.com> (Woodrow Douglass via buildroot's message of "Tue, 6 Aug 2024 09:05:53 -0400")
Hi Woodrow,
On Tue, Aug 06 2024, Woodrow Douglass via buildroot wrote:
> diff --git a/package/chicken/chicken.mk b/package/chicken/chicken.mk
> index 0520280134..e7a2384f5a 100644
> --- a/package/chicken/chicken.mk
> +++ b/package/chicken/chicken.mk
> @@ -16,8 +16,6 @@ CHICKEN_INSTALL_STAGING = YES
> # values that have an effect, or pass "unused" here
> ifeq ($(NORMALIZED_ARCH),x86_64)
> CHICKEN_ARCH = x86-64
> -else ifeq ($(NORMALIZED_ARCH),xtensa)
> -CHICKEN_ARCH = xtensa
> else
> CHICKEN_ARCH = unused
> endif
> @@ -25,6 +23,7 @@ endif
> CHICKEN_MAKE_OPTS = \
> ARCH="$(CHICKEN_ARCH)" \
> C_COMPILER="$(TARGET_CC)" \
> + C_COMPILER_OPTIONS="$(TARGET_CFLAGS) -fwrapv -DHAVE_CHICKEN_CONFIG_H -DC_ENABLE_PTABLES" \
I think C_COMPILER_OPTIMIZATION_OPTIONS is better for this purpose.
C_COMPILER_OPTIMIZATION_OPTIONS usage is documented in README and
config.make, while C_COMPILER_OPTIONS looks like an internal
implementation detail. C_COMPILER_OPTIMIZATION_OPTIONS allows Buildroot
users to override upstream default optimization options via
BR2_OPTIMIZE_x, or debug options via BR2_DEBUG_x. Another advantage of
not using C_COMPILER_OPTIONS is that you won't have to copy its default
value here.
baruch
> CXX_COMPILER="$(TARGET_CXX)" \
> PREFIX=/usr \
> PLATFORM=linux \
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-08-06 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 13:05 [Buildroot] [PATCH] package/chicken: pass TARGET_CFLAGS to chicken build system explicitly Woodrow Douglass via buildroot
2024-08-06 14:26 ` Baruch Siach via buildroot [this message]
2024-08-12 12:43 ` [Buildroot] [PATCH] Revert "package/chicken: move literals into text section for xtensa architecture" Woodrow Douglass via buildroot
2024-08-12 12:44 ` [Buildroot] [PATCH] package/chicken: pass TARGET_CFLAGS to chicken build system explicitly Woodrow Douglass via buildroot
2024-08-12 12:46 ` Woodrow Douglass via buildroot
2024-08-12 12:56 ` Woodrow Douglass via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qx93exs.fsf@tarshish \
--to=buildroot@buildroot.org \
--cc=baruch@tkos.co.il \
--cc=wdouglass@carnegierobotics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.