From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 080C3C3DA5D for ; Fri, 19 Jul 2024 09:11:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sUjdJ-0003yB-2H; Fri, 19 Jul 2024 05:10:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sUjdI-0003uo-5X for qemu-devel@nongnu.org; Fri, 19 Jul 2024 05:10:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sUjdG-0005Al-QH for qemu-devel@nongnu.org; Fri, 19 Jul 2024 05:10:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721380229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VWLB4MhFLKQuKKNWu8bxqo6GJ1gPjAUMi8mZuXQm9F8=; b=Y6sKjvAs2qZmbLyM/Wpf2ajG2eruBFVptw2FXjQXoma/47TFYg23ZQYuo508tSziNn9p4b D9p/nN4vF/5Q9UxXkb4s59zP8pCeXx0J5X/brk2dL6trnX8RV5y8wiNfeSCFrvgfShAgcS zZinHkhirnhV370p8tFf8W+xEpKW24I= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-50-MWDI65tFNAOkSS42tOHk3w-1; Fri, 19 Jul 2024 05:10:23 -0400 X-MC-Unique: MWDI65tFNAOkSS42tOHk3w-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 576FE1979042; Fri, 19 Jul 2024 09:10:19 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.65]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4A5141955D52; Fri, 19 Jul 2024 09:10:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 2174021E668A; Fri, 19 Jul 2024 11:10:15 +0200 (CEST) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy Cc: Markus Armbruster , qemu-block@nongnu.org, raphael@enfabrica.net, mst@redhat.com, qemu-devel@nongnu.org, eblake@redhat.com, eduardo@habkost.net, berrange@redhat.com, pbonzini@redhat.com, hreitz@redhat.com, kwolf@redhat.com, yc-core@yandex-team.ru Subject: Re: [PATCH v5 3/3] qapi: introduce device-sync-config In-Reply-To: <91cda3d7-0d25-44de-be1c-ddcc7d93d2b7@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Fri, 19 Jul 2024 11:31:07 +0300") References: <20240625121843.120035-1-vsementsov@yandex-team.ru> <20240625121843.120035-4-vsementsov@yandex-team.ru> <87cynbm7fj.fsf@pond.sub.org> <91cda3d7-0d25-44de-be1c-ddcc7d93d2b7@yandex-team.ru> Date: Fri, 19 Jul 2024 11:10:15 +0200 Message-ID: <878qxxvjbc.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Vladimir Sementsov-Ogievskiy writes: > On 18.07.24 11:27, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Add command to sync config from vhost-user backend to the device. It >>> may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not >>> triggered interrupt to the guest or just not available (not supported >>> by vhost-user server). >>> >>> Command result is racy if allow it during migration. Let's allow the >>> sync only in RUNNING state. >> >> Is this still accurate? The runstate_is_running() check is gone in >> v4, the migration_is_running() check remains. > > Right, better to fix commit message like: > > Command result is racy if allow it during migration. Let's not allow it. Suggest "Let's not allow that." Thanks! >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >> >> QAPI schema and QMP part: >> Signed-off-by: Markus Armbruster