From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-block@nongnu.org, raphael@enfabrica.net, mst@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com, eblake@redhat.com,
eduardo@habkost.net, berrange@redhat.com, pbonzini@redhat.com,
hreitz@redhat.com, kwolf@redhat.com, yc-core@yandex-team.ru
Subject: Re: [PATCH v5 1/3] qdev-monitor: add option to report GenericError from find_device_state
Date: Thu, 18 Jul 2024 10:30:26 +0200 [thread overview]
Message-ID: <878qxzm7a5.fsf@pond.sub.org> (raw)
In-Reply-To: <20240625121843.120035-2-vsementsov@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Tue, 25 Jun 2024 15:18:41 +0300")
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
> Here we just prepare for the following patch, making possible to report
> GenericError as recommended.
>
> This patch doesn't aim to prevent further use of DeviceNotFound by
> future interfaces:
>
> - find_device_state() is used in blk_by_qdev_id() and qmp_get_blk()
> functions, which may lead to spread of DeviceNotFound anyway
> - also, nothing prevent simply copy-pasting find_device_state() calls
> with false argument
A possible way to reduce the likelihood of further spread:
1. Rename find_device_state() to find_device_state_legacy().
2. New find_device_state() that reports GenericError.
Could also be done in a follow-up.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
The patch does what it says on the tin, so
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2024-07-18 8:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 12:18 [PATCH v5 0/3] vhost-user-blk: live resize additional APIs Vladimir Sementsov-Ogievskiy
2024-06-25 12:18 ` [PATCH v5 1/3] qdev-monitor: add option to report GenericError from find_device_state Vladimir Sementsov-Ogievskiy
2024-07-18 8:30 ` Markus Armbruster [this message]
2024-06-25 12:18 ` [PATCH v5 2/3] vhost-user-blk: split vhost_user_blk_sync_config() Vladimir Sementsov-Ogievskiy
2024-06-25 12:18 ` [PATCH v5 3/3] qapi: introduce device-sync-config Vladimir Sementsov-Ogievskiy
2024-07-18 8:27 ` Markus Armbruster
2024-07-19 8:31 ` Vladimir Sementsov-Ogievskiy
2024-07-19 9:10 ` Markus Armbruster
2024-07-01 12:42 ` [PATCH v5 0/3] vhost-user-blk: live resize additional APIs Raphael Norwitz
2024-07-01 20:55 ` Michael S. Tsirkin
2024-08-01 8:35 ` Vladimir Sementsov-Ogievskiy
2024-08-01 8:37 ` Michael S. Tsirkin
2024-08-01 8:42 ` Vladimir Sementsov-Ogievskiy
2024-07-11 8:53 ` Vladimir Sementsov-Ogievskiy
2024-07-18 8:31 ` Markus Armbruster
2024-07-19 8:33 ` Vladimir Sementsov-Ogievskiy
2024-09-11 9:51 ` Michael S. Tsirkin
2024-09-20 9:43 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qxzm7a5.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael@enfabrica.net \
--cc=vsementsov@yandex-team.ru \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.